You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Qian Zhang <zh...@gmail.com> on 2019/01/22 08:58:54 UTC
Review Request 69805: Fixed a minor coding error in
`createSandboxDirectory`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69805/
-----------------------------------------------------------
Review request for mesos and Gilbert Song.
Repository: mesos
Description
-------
Fixed a minor coding error in `createSandboxDirectory`.
Diffs
-----
src/slave/paths.cpp 9fd37f5456d45d520d6062577c1692a4be627c0e
Diff: https://reviews.apache.org/r/69805/diff/1/
Testing
-------
Thanks,
Qian Zhang
Re: Review Request 69805: Fixed a minor coding error in
`createSandboxDirectory`.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69805/#review212197
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On Jan. 22, 2019, 12:58 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69805/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2019, 12:58 a.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed a minor coding error in `createSandboxDirectory`.
>
>
> Diffs
> -----
>
> src/slave/paths.cpp 9fd37f5456d45d520d6062577c1692a4be627c0e
>
>
> Diff: https://reviews.apache.org/r/69805/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 69805: Fixed a minor coding error in
`createSandboxDirectory`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69805/#review212194
-----------------------------------------------------------
PASS: Mesos patch 69805 was successfully built and tested.
Reviews applied: `['69805']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2805/mesos-review-69805
- Mesos Reviewbot Windows
On Jan. 22, 2019, 8:58 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69805/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2019, 8:58 a.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed a minor coding error in `createSandboxDirectory`.
>
>
> Diffs
> -----
>
> src/slave/paths.cpp 9fd37f5456d45d520d6062577c1692a4be627c0e
>
>
> Diff: https://reviews.apache.org/r/69805/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 69805: Fixed a minor coding error in
`createSandboxDirectory`.
Posted by Gilbert Song <so...@gmail.com>.
> On Jan. 22, 2019, 1:53 p.m., Benjamin Bannier wrote:
> > Do you plan to backport this? I am not sure this is a minor error like in stated in the comment since it could lead to leaking of private data (see comment right above). We should probably also have a proper ticket for this.
It was already backported to 1.6.x
- Gilbert
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69805/#review212199
-----------------------------------------------------------
On Jan. 22, 2019, 12:58 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69805/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2019, 12:58 a.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed a minor coding error in `createSandboxDirectory`.
>
>
> Diffs
> -----
>
> src/slave/paths.cpp 9fd37f5456d45d520d6062577c1692a4be627c0e
>
>
> Diff: https://reviews.apache.org/r/69805/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>
Re: Review Request 69805: Fixed a minor coding error in
`createSandboxDirectory`.
Posted by Benjamin Bannier <be...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69805/#review212199
-----------------------------------------------------------
Do you plan to backport this? I am not sure this is a minor error like in stated in the comment since it could lead to leaking of private data (see comment right above). We should probably also have a proper ticket for this.
- Benjamin Bannier
On Jan. 22, 2019, 9:58 a.m., Qian Zhang wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69805/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2019, 9:58 a.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Fixed a minor coding error in `createSandboxDirectory`.
>
>
> Diffs
> -----
>
> src/slave/paths.cpp 9fd37f5456d45d520d6062577c1692a4be627c0e
>
>
> Diff: https://reviews.apache.org/r/69805/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Qian Zhang
>
>