You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "gavinchou (via GitHub)" <gi...@apache.org> on 2026/05/22 09:47:38 UTC

[PR] Fix meta tool build on master [doris]

gavinchou opened a new pull request, #63540:
URL: https://github.com/apache/doris/pull/63540

   ## Proposed changes
   
   Pick the meta_tool build fix to master.
   
   ## Testing
   
   - sh format_code.sh be/src/tools/meta_tool.cpp
   - sh build.sh --be --meta-tool -j100


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] Fix meta tool build on master [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #63540:
URL: https://github.com/apache/doris/pull/63540#issuecomment-4521933330

   PR approved by anyone and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] Fix meta tool build on master [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63540:
URL: https://github.com/apache/doris/pull/63540#issuecomment-4518093613

   
   <details>
   <summary>TPC-DS: <b>Total hot run time: 170221 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpcds-tools
   TPC-DS sf100 test result on commit 3588db032ca4902f0a5c00524c5fc062b284c597, data reload: false
   
   query5	4362	665	531	531
   query6	351	225	202	202
   query7	4219	567	323	323
   query8	319	242	220	220
   query9	8874	3944	3950	3944
   query10	439	339	295	295
   query11	5831	2441	2182	2182
   query12	181	128	126	126
   query13	1288	621	440	440
   query14	5996	5363	5108	5108
   query14_1	4355	4352	4334	4334
   query15	208	202	179	179
   query16	1004	448	422	422
   query17	1132	697	573	573
   query18	2435	480	348	348
   query19	209	198	155	155
   query20	133	134	129	129
   query21	215	139	112	112
   query22	13656	13573	13267	13267
   query23	17335	16380	16166	16166
   query23_1	16075	16111	16221	16111
   query24	7545	1721	1295	1295
   query24_1	1302	1305	1288	1288
   query25	551	468	408	408
   query26	1298	326	178	178
   query27	2702	548	347	347
   query28	4492	1944	1996	1944
   query29	1015	656	512	512
   query30	306	245	200	200
   query31	1116	1067	945	945
   query32	90	79	74	74
   query33	548	370	318	318
   query34	1175	1139	639	639
   query35	787	792	683	683
   query36	1324	1366	1156	1156
   query37	161	112	94	94
   query38	3212	3164	3100	3100
   query39	933	960	899	899
   query39_1	874	882	871	871
   query40	235	151	129	129
   query41	73	70	68	68
   query42	116	113	110	110
   query43	323	331	290	290
   query44	
   query45	211	208	201	201
   query46	1060	1179	724	724
   query47	2312	2367	2163	2163
   query48	404	436	312	312
   query49	656	505	396	396
   query50	942	348	261	261
   query51	4308	4358	4296	4296
   query52	112	110	97	97
   query53	260	285	212	212
   query54	350	316	305	305
   query55	99	100	87	87
   query56	349	303	317	303
   query57	1384	1374	1301	1301
   query58	296	273	273	273
   query59	1591	1638	1445	1445
   query60	314	325	316	316
   query61	156	154	158	154
   query62	663	630	546	546
   query63	232	199	216	199
   query64	2396	780	615	615
   query65	
   query66	1746	468	354	354
   query67	29986	29983	29885	29885
   query68	
   query69	461	334	296	296
   query70	1021	964	1017	964
   query71	316	278	274	274
   query72	3090	2674	2447	2447
   query73	862	758	406	406
   query74	5043	4911	4708	4708
   query75	2666	2593	2252	2252
   query76	2265	1132	790	790
   query77	411	406	328	328
   query78	12169	12081	11672	11672
   query79	1435	1051	722	722
   query80	654	535	449	449
   query81	455	276	254	254
   query82	1373	160	125	125
   query83	359	274	254	254
   query84	258	146	112	112
   query85	890	549	438	438
   query86	397	351	314	314
   query87	3449	3361	3221	3221
   query88	3509	2663	2622	2622
   query89	431	386	337	337
   query90	1909	186	193	186
   query91	178	176	146	146
   query92	84	79	73	73
   query93	1561	1403	906	906
   query94	546	353	299	299
   query95	681	403	367	367
   query96	1049	778	327	327
   query97	2718	2774	2550	2550
   query98	235	229	222	222
   query99	1103	1119	988	988
   Total cold run time: 253521 ms
   Total hot run time: 170221 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] Fix meta tool build on master [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63540:
URL: https://github.com/apache/doris/pull/63540#issuecomment-4517596261

   
   Thank you for your contribution to Apache Doris.
   Don't know what should be done next? See [How to process your PR](https://cwiki.apache.org/confluence/display/DORIS/How+to+process+your+PR).
   
   Please clearly describe your PR:
   1. What problem was fixed (it's best to include specific error reporting information). How it was fixed.
   2. Which behaviors were modified. What was the previous behavior, what is it now, why was it modified, and what possible impacts might there be.
   3. What features were added. Why was this function added?
   4. Which code was refactored and why was this part of the code refactored?
   5. Which functions were optimized and what is the difference before and after the optimization?
       


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] Fix meta tool build on master [doris]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #63540:
URL: https://github.com/apache/doris/pull/63540#issuecomment-4521933054

   PR approved by at least one committer and no changes requested.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] Fix meta tool build on master [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63540:
URL: https://github.com/apache/doris/pull/63540#issuecomment-4532063925

   skip buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] Fix meta tool build on master [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen merged PR #63540:
URL: https://github.com/apache/doris/pull/63540


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] Fix meta tool build on master [doris]

Posted by "gavinchou (via GitHub)" <gi...@apache.org>.
gavinchou commented on PR #63540:
URL: https://github.com/apache/doris/pull/63540#issuecomment-4517596610

   run buildall


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] Fix meta tool build on master [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63540:
URL: https://github.com/apache/doris/pull/63540#issuecomment-4518573849

   # BE UT Coverage Report
   Increment line coverage ` ` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/3588db032ca4902f0a5c00524c5fc062b284c597_3588db032ca4902f0a5c00524c5fc062b284c597/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/3588db032ca4902f0a5c00524c5fc062b284c597_3588db032ca4902f0a5c00524c5fc062b284c597/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 53.64% (20759/38697) |
   | Line Coverage     | 37.25% (196638/527888) |
   | Region Coverage   | 33.58% (154113/458975) |
   | Branch Coverage   | 34.58% (67134/194136) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] Fix meta tool build on master [doris]

Posted by "gavinchou (via GitHub)" <gi...@apache.org>.
gavinchou commented on PR #63540:
URL: https://github.com/apache/doris/pull/63540#issuecomment-4524680294

   skip code-review


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] Fix meta tool build on master [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63540:
URL: https://github.com/apache/doris/pull/63540#issuecomment-4518030065

   
   <details>
   <summary>TPC-H: <b>Total hot run time: 31818 ms</b></summary>
   
   ```
   machine: 'aliyun_ecs.c7a.8xlarge_32C64G'
   scripts: https://github.com/apache/doris/tree/master/tools/tpch-tools
   Tpch sf100 test result on commit 3588db032ca4902f0a5c00524c5fc062b284c597, data reload: false
   
   ------ Round 1 ----------------------------------
   orders	Doris	NULL	NULL	0	0	0	NULL	0	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
   ============================================
   q1	17665	3999	4053	3999
   q2	q3	10793	1495	825	825
   q4	4705	485	341	341
   q5	7536	2323	2150	2150
   q6	241	177	139	139
   q7	924	784	639	639
   q8	9377	1650	1603	1603
   q9	5153	4954	4948	4948
   q10	6432	2108	1834	1834
   q11	442	277	249	249
   q12	635	417	298	298
   q13	18081	3328	2841	2841
   q14	271	256	238	238
   q15	q16	821	779	714	714
   q17	1020	979	1031	979
   q18	6922	5776	5565	5565
   q19	1347	1327	1033	1033
   q20	664	467	308	308
   q21	6159	2855	2741	2741
   q22	458	374	460	374
   Total cold run time: 99646 ms
   Total hot run time: 31818 ms
   
   ----- Round 2, with runtime_filter_mode=off -----
   orders	Doris	NULL	NULL	150000000	42	6422171781	NULL	22778155	NULL	NULL	2023-12-26 18:27:23	2023-12-26 18:42:55	NULL	utf-8	NULL	NULL	
   ============================================
   q1	4657	4627	4525	4525
   q2	q3	4871	5267	4564	4564
   q4	2145	2189	1434	1434
   q5	4864	4620	4608	4608
   q6	228	178	127	127
   q7	1954	1771	1517	1517
   q8	2372	2055	2116	2055
   q9	7675	7372	7222	7222
   q10	4506	4426	4008	4008
   q11	528	381	366	366
   q12	706	730	528	528
   q13	2975	3462	2835	2835
   q14	277	278	252	252
   q15	q16	686	716	614	614
   q17	1269	1255	1250	1250
   q18	7406	6801	6784	6784
   q19	1151	1112	1119	1112
   q20	2207	2213	1922	1922
   q21	5316	4689	4639	4639
   q22	535	465	401	401
   Total cold run time: 56328 ms
   Total hot run time: 50763 ms
   ```
   </details>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org


Re: [PR] Fix meta tool build on master [doris]

Posted by "hello-stephen (via GitHub)" <gi...@apache.org>.
hello-stephen commented on PR #63540:
URL: https://github.com/apache/doris/pull/63540#issuecomment-4518841671

   # BE Regression && UT Coverage Report
   Increment line coverage `100% (0/0)` :tada:
   
   [Increment coverage report](http://coverage.selectdb-in.cc/coverage/63540_3588db032ca4902f0a5c00524c5fc062b284c597_merge/increment_report/index.html)
   [Complete coverage report](http://coverage.selectdb-in.cc/coverage/63540_3588db032ca4902f0a5c00524c5fc062b284c597_merge/report/index.html)
   | Category          | Coverage           |
   |-------------------|--------------------|
   | Function Coverage | 73.64% (27912/37903) |
   | Line Coverage     | 57.57% (303118/526542) |
   | Region Coverage   | 54.70% (253503/463404) |
   | Branch Coverage   | 56.22% (109559/194863) |


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org