You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "cstamas (via GitHub)" <gi...@apache.org> on 2024/03/03 17:23:25 UTC
[PR] [MGPG-102] Drop MAT [maven-gpg-plugin]
cstamas opened a new pull request, #69:
URL: https://github.com/apache/maven-gpg-plugin/pull/69
Drop MAT, use Resolver, as we have min 3.2.5
---
https://issues.apache.org/jira/browse/MGPG-102
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MGPG-102] Drop MAT [maven-gpg-plugin]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on code in PR #69:
URL: https://github.com/apache/maven-gpg-plugin/pull/69#discussion_r1510342521
##########
src/main/java/org/apache/maven/plugins/gpg/SignAndDeployFileMojo.java:
##########
@@ -257,6 +219,15 @@ public class SignAndDeployFileMojo extends AbstractGpgMojo {
@Parameter(property = "files")
private String files;
+ /**
+ * @since 3.0.0
+ */
+ @Parameter(defaultValue = "${session}", readonly = true, required = true)
Review Comment:
Coz did not want to mix in that change, so I did "as it was for the rest". anyway, pushed now a change that moves ALL to component.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MGPG-102] Drop MAT [maven-gpg-plugin]
Posted by "hboutemy (via GitHub)" <gi...@apache.org>.
hboutemy commented on code in PR #69:
URL: https://github.com/apache/maven-gpg-plugin/pull/69#discussion_r1510339549
##########
src/main/java/org/apache/maven/plugins/gpg/SignAndDeployFileMojo.java:
##########
@@ -257,6 +219,15 @@ public class SignAndDeployFileMojo extends AbstractGpgMojo {
@Parameter(property = "files")
private String files;
+ /**
+ * @since 3.0.0
+ */
+ @Parameter(defaultValue = "${session}", readonly = true, required = true)
Review Comment:
why not @Component?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [MGPG-102] Drop MAT used in sign-and-deploy-file [maven-gpg-plugin]
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas merged PR #69:
URL: https://github.com/apache/maven-gpg-plugin/pull/69
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org