You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Kathleen Ting <ka...@apache.org> on 2012/04/03 00:23:54 UTC
Review Request: Patch for SQOOP-474
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4614/
-----------------------------------------------------------
Review request for Sqoop and Arvind Prabhakar.
Summary
-------
Before triggering the bounding value query construction, in addition to checking that the user has specified a split by option, also take into account that the number of mappers is 1.
This addresses bug SQOOP-474.
https://issues.apache.org/jira/browse/SQOOP-474
Diffs
-----
./src/java/org/apache/sqoop/mapreduce/DataDrivenImportJob.java 1308530
Diff: https://reviews.apache.org/r/4614/diff
Testing
-------
Ran unit tests. Confirmed that, with the fix, the console output does not have the boundary query in it (i.e. INFO db.DataDrivenDBInputFormat: BoundingValsQuery).
Thanks,
Kathleen
Re: Review Request: Patch for SQOOP-474
Posted by Bilung Lee <bl...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4614/#review6721
-----------------------------------------------------------
Ship it!
- Bilung
On 2012-04-05 22:14:27, Kathleen Ting wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4614/
> -----------------------------------------------------------
>
> (Updated 2012-04-05 22:14:27)
>
>
> Review request for Sqoop and Bilung Lee.
>
>
> Summary
> -------
>
> Before triggering the bounding value query construction, in addition to checking that the user has specified a split by option, also take into account that the number of mappers is 1.
>
>
> This addresses bug SQOOP-474.
> https://issues.apache.org/jira/browse/SQOOP-474
>
>
> Diffs
> -----
>
> ./src/java/org/apache/sqoop/mapreduce/DataDrivenImportJob.java 1309506
>
> Diff: https://reviews.apache.org/r/4614/diff
>
>
> Testing
> -------
>
> Ran unit tests. Confirmed that, with the fix, the console output does not have the boundary query in it (i.e. INFO db.DataDrivenDBInputFormat: BoundingValsQuery).
>
>
> Thanks,
>
> Kathleen
>
>
Re: Review Request: Patch for SQOOP-474
Posted by Kathleen Ting <ka...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4614/
-----------------------------------------------------------
(Updated 2012-04-05 22:14:27.818185)
Review request for Sqoop and Bilung Lee.
Summary
-------
Before triggering the bounding value query construction, in addition to checking that the user has specified a split by option, also take into account that the number of mappers is 1.
This addresses bug SQOOP-474.
https://issues.apache.org/jira/browse/SQOOP-474
Diffs
-----
./src/java/org/apache/sqoop/mapreduce/DataDrivenImportJob.java 1309506
Diff: https://reviews.apache.org/r/4614/diff
Testing
-------
Ran unit tests. Confirmed that, with the fix, the console output does not have the boundary query in it (i.e. INFO db.DataDrivenDBInputFormat: BoundingValsQuery).
Thanks,
Kathleen
Re: Review Request: Patch for SQOOP-474
Posted by Kathleen Ting <ka...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4614/
-----------------------------------------------------------
(Updated 2012-04-05 22:14:12.420696)
Review request for Sqoop and Arvind Prabhakar.
Changes
-------
Rebased on SQOOP-468
Summary
-------
Before triggering the bounding value query construction, in addition to checking that the user has specified a split by option, also take into account that the number of mappers is 1.
This addresses bug SQOOP-474.
https://issues.apache.org/jira/browse/SQOOP-474
Diffs (updated)
-----
./src/java/org/apache/sqoop/mapreduce/DataDrivenImportJob.java 1309506
Diff: https://reviews.apache.org/r/4614/diff
Testing
-------
Ran unit tests. Confirmed that, with the fix, the console output does not have the boundary query in it (i.e. INFO db.DataDrivenDBInputFormat: BoundingValsQuery).
Thanks,
Kathleen
Re: Review Request: Patch for SQOOP-474
Posted by Kathleen Ting <ka...@apache.org>.
> On 2012-04-03 20:53:06, Cheolsoo Park wrote:
> > Hi Kate, your patch looks good. I only want to mention that I made some change to the same area of code at SQOOP-468, which Jarec is going to submit soon. So you will need to rebase your patch once it is committed.
> >
> > In my patch, I factored out that area of code into a separate function (buildBoundaryQuery). To achieve what you're doing here, you can change the following line:
> >
> > private String buildBoundaryQuery(String col, String query) {
> > if (col == null) { // change to --> if (col == null || options.getNumMappers() == 1) {
> > return "";
> > }
> > ...
> > }
> >
> > I have tested this in my workspace by myself and seen no issues. Please let me know if you have any concerns/questions.
Thanks Cheolsoo. I've rebased SQOOP-474 on your SQOOP-468.
- Kathleen
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4614/#review6664
-----------------------------------------------------------
On 2012-04-02 22:23:54, Kathleen Ting wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4614/
> -----------------------------------------------------------
>
> (Updated 2012-04-02 22:23:54)
>
>
> Review request for Sqoop and Arvind Prabhakar.
>
>
> Summary
> -------
>
> Before triggering the bounding value query construction, in addition to checking that the user has specified a split by option, also take into account that the number of mappers is 1.
>
>
> This addresses bug SQOOP-474.
> https://issues.apache.org/jira/browse/SQOOP-474
>
>
> Diffs
> -----
>
> ./src/java/org/apache/sqoop/mapreduce/DataDrivenImportJob.java 1308530
>
> Diff: https://reviews.apache.org/r/4614/diff
>
>
> Testing
> -------
>
> Ran unit tests. Confirmed that, with the fix, the console output does not have the boundary query in it (i.e. INFO db.DataDrivenDBInputFormat: BoundingValsQuery).
>
>
> Thanks,
>
> Kathleen
>
>
Re: Review Request: Patch for SQOOP-474
Posted by Cheolsoo Park <ch...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/4614/#review6664
-----------------------------------------------------------
Hi Kate, your patch looks good. I only want to mention that I made some change to the same area of code at SQOOP-468, which Jarec is going to submit soon. So you will need to rebase your patch once it is committed.
In my patch, I factored out that area of code into a separate function (buildBoundaryQuery). To achieve what you're doing here, you can change the following line:
private String buildBoundaryQuery(String col, String query) {
if (col == null) { // change to --> if (col == null || options.getNumMappers() == 1) {
return "";
}
...
}
I have tested this in my workspace by myself and seen no issues. Please let me know if you have any concerns/questions.
- Cheolsoo
On 2012-04-02 22:23:54, Kathleen Ting wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/4614/
> -----------------------------------------------------------
>
> (Updated 2012-04-02 22:23:54)
>
>
> Review request for Sqoop and Arvind Prabhakar.
>
>
> Summary
> -------
>
> Before triggering the bounding value query construction, in addition to checking that the user has specified a split by option, also take into account that the number of mappers is 1.
>
>
> This addresses bug SQOOP-474.
> https://issues.apache.org/jira/browse/SQOOP-474
>
>
> Diffs
> -----
>
> ./src/java/org/apache/sqoop/mapreduce/DataDrivenImportJob.java 1308530
>
> Diff: https://reviews.apache.org/r/4614/diff
>
>
> Testing
> -------
>
> Ran unit tests. Confirmed that, with the fix, the console output does not have the boundary query in it (i.e. INFO db.DataDrivenDBInputFormat: BoundingValsQuery).
>
>
> Thanks,
>
> Kathleen
>
>