You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@myfaces.apache.org by GitBox <gi...@apache.org> on 2021/06/23 20:01:30 UTC

[GitHub] [myfaces] melloware commented on a change in pull request #211: MYFACES-4404 -- Log viewstate string

melloware commented on a change in pull request #211:
URL: https://github.com/apache/myfaces/pull/211#discussion_r657421455



##########
File path: impl/src/main/java/org/apache/myfaces/renderkit/html/HtmlResponseStateManager.java
##########
@@ -121,6 +121,9 @@ private void writeViewStateField(FacesContext facesContext, ResponseWriter respo
     {
         String serializedState = getStateCache(facesContext).getStateTokenProcessor(facesContext)
                 .encode(facesContext, savedState);
+
+        log.info("Writing serialized viewstate string: " + serializedState);

Review comment:
       This will always concat the string shouldn't you wrap this in something like...
   
   ```
   if (log.isInfoEnabled()) { log.info() )} 
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org