You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@superset.apache.org by gi...@git.apache.org on 2017/09/08 22:15:09 UTC

[GitHub] xrmx commented on a change in pull request #3436: Adding hook for external password store for databases

xrmx commented on a change in pull request #3436: Adding hook for external password store for databases
URL: https://github.com/apache/incubator-superset/pull/3436#discussion_r137900600
 
 

 ##########
 File path: superset/config.py
 ##########
 @@ -60,6 +60,15 @@
 # SQLALCHEMY_DATABASE_URI = 'mysql://myapp@localhost/myapp'
 # SQLALCHEMY_DATABASE_URI = 'postgresql://root:password@localhost/myapp'
 
+# In order to hook up a custom password store for all SQLACHEMY connections
 
 Review comment:
   Better add documentation to documentation instead of config files. You can just set 
   `SQLALCHEMY_CUSTOM_PASSWORD_STORE = False` here
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services