You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "mihailoale-db (via GitHub)" <gi...@apache.org> on 2025/05/08 18:05:19 UTC
[PR] [SPARK-52046] [SQL] Prettify OuterReference names when using toPrettySQL [spark]
mihailoale-db opened a new pull request, #50836:
URL: https://github.com/apache/spark/pull/50836
### What changes were proposed in this pull request?
In this PR I propose that we remove backticks, qualifiers from `OuterReference` when creating name. In other words, name for `column` which is an outer reference would be `outer(column)` instead of `outer(catalog.db.table.column)`.
### Why are the changes needed?
To ease development of single-pass analyzer and improve names in fixed-point implementation.
### Does this PR introduce _any_ user-facing change?
Schema changes in a way that `OuterReference` name doesn't contain backticks and qualifiers.
### How was this patch tested?
Existing tests.
### Was this patch authored or co-authored using generative AI tooling?
No.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-52046] [SQL] Prettify OuterReference on AggregateExpression names when using toPrettySQL [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #50836:
URL: https://github.com/apache/spark/pull/50836#issuecomment-2867295389
thanks, merging to master!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-52046] [SQL] Prettify OuterReference on AggregateExpression names when using toPrettySQL [spark]
Posted by "mihailoale-db (via GitHub)" <gi...@apache.org>.
mihailoale-db commented on PR #50836:
URL: https://github.com/apache/spark/pull/50836#issuecomment-2867039944
@cloud-fan PTAL when you have time. Thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-52046] [SQL] Prettify OuterReference on AggregateExpression names when using toPrettySQL [spark]
Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan closed pull request #50836: [SPARK-52046] [SQL] Prettify OuterReference on AggregateExpression names when using toPrettySQL
URL: https://github.com/apache/spark/pull/50836
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-52046] [SQL] Prettify OuterReference on AggregateExpression names when using toPrettySQL [spark]
Posted by "mihailoale-db (via GitHub)" <gi...@apache.org>.
mihailoale-db commented on PR #50836:
URL: https://github.com/apache/spark/pull/50836#issuecomment-2865979031
@cloud-fan Please propose a better name for `PULL_OUT_OUTER_REFERENCE_BEFORE_COMPUTING_NAME` if necessary as we now guard both pulling out outer references and prettifying of `OuterReference(AggregateExpression(...))` pattern.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org