You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@inlong.apache.org by "gosonzhang (via GitHub)" <gi...@apache.org> on 2024/04/25 12:20:11 UTC
[PR] [INLONG-10066][DataProxy] Optimize the related configuration settings in the CommonConfigHolder.java file [inlong]
gosonzhang opened a new pull request, #10079:
URL: https://github.com/apache/inlong/pull/10079
Fixes #10066
1. Uniformly configure the Key to lowercase, and use "." to classify;
2. Configure pre-reading according to different types;
3. Optimize the acquisition of configuration values, and check whether key configurations are empty and legal;
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-10066][DataProxy] Optimize the related configuration settings in the CommonConfigHolder.java file [inlong]
Posted by "gosonzhang (via GitHub)" <gi...@apache.org>.
gosonzhang merged PR #10079:
URL: https://github.com/apache/inlong/pull/10079
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-10066][DataProxy] Optimize the related configuration settings in the CommonConfigHolder.java file [inlong]
Posted by "dockerzhang (via GitHub)" <gi...@apache.org>.
dockerzhang commented on code in PR #10079:
URL: https://github.com/apache/inlong/pull/10079#discussion_r1580344407
##########
inlong-dataproxy/conf/common.properties:
##########
@@ -18,24 +18,24 @@
# manager open api address and auth key
manager.hosts=127.0.0.1:8083
-manager.auth.secretId=
-manager.auth.secretKey=
+manager.auth.secret.id=
+manager.auth.secret.key=
# proxy cluster name
proxy.cluster.name=default_dataproxy
proxy.cluster.tag=default_cluster
-proxy.cluster.extTag=default=true
-proxy.cluster.inCharges=admin
+proxy.cluster.ext.tag=default=true
+proxy.cluster.incharges=admin
# synchronize interval of meta config (millisecond)
meta.config.sync.interval.ms=10000
# whether to startup using the local metadata.json file without connecting to the Manager
-startup.using.local.meta.file.enable=false
+meta.config.startup.using.local.file.enable=false
# metric config
metricDomains=DataProxy
metricDomains.DataProxy.domainListeners=org.apache.inlong.dataproxy.metrics.prometheus.PrometheusMetricListener
metricDomains.DataProxy.snapshotInterval=60000
-prometheusHttpPort=9081
+online.metric.prometheus.http.port=9081
Review Comment:
```suggestion
metric.prometheus.http.port=9081
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [INLONG-10066][DataProxy] Optimize the related configuration settings in the CommonConfigHolder.java file [inlong]
Posted by "dockerzhang (via GitHub)" <gi...@apache.org>.
dockerzhang commented on code in PR #10079:
URL: https://github.com/apache/inlong/pull/10079#discussion_r1580344407
##########
inlong-dataproxy/conf/common.properties:
##########
@@ -18,24 +18,24 @@
# manager open api address and auth key
manager.hosts=127.0.0.1:8083
-manager.auth.secretId=
-manager.auth.secretKey=
+manager.auth.secret.id=
+manager.auth.secret.key=
# proxy cluster name
proxy.cluster.name=default_dataproxy
proxy.cluster.tag=default_cluster
-proxy.cluster.extTag=default=true
-proxy.cluster.inCharges=admin
+proxy.cluster.ext.tag=default=true
+proxy.cluster.incharges=admin
# synchronize interval of meta config (millisecond)
meta.config.sync.interval.ms=10000
# whether to startup using the local metadata.json file without connecting to the Manager
-startup.using.local.meta.file.enable=false
+meta.config.startup.using.local.file.enable=false
# metric config
metricDomains=DataProxy
metricDomains.DataProxy.domainListeners=org.apache.inlong.dataproxy.metrics.prometheus.PrometheusMetricListener
metricDomains.DataProxy.snapshotInterval=60000
-prometheusHttpPort=9081
+online.metric.prometheus.http.port=9081
Review Comment:
```suggestion
metric.prometheus.http.port=9081
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@inlong.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org