You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@livy.apache.org by GitBox <gi...@apache.org> on 2020/08/18 19:57:27 UTC

[GitHub] [incubator-livy] AFFogarty commented on a change in pull request #303: Add app state to AppInfo

AFFogarty commented on a change in pull request #303:
URL: https://github.com/apache/incubator-livy/pull/303#discussion_r472444662



##########
File path: server/src/test/scala/org/apache/livy/server/interactive/InteractiveSessionServletSpec.scala
##########
@@ -168,7 +168,10 @@ class InteractiveSessionServletSpec extends BaseInteractiveServletSpec {
     val proxyUser = "proxyUser"
     val state = SessionState.Running
     val kind = Spark
-    val appInfo = AppInfo(Some("DRIVER LOG URL"), Some("SPARK UI URL"))
+    val appInfo = AppInfo(
+      Some("DRIVER LOG URL"),
+      Some("SPARK UI URL"),
+      Some(SparkApp.State.RUNNING))

Review comment:
       Added verification that `appState=None` gets serialized to `"appState": null`.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org