You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@taverna.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2015/07/13 16:11:05 UTC
[jira] [Commented] (TAVERNA-846) Typo and annotation missing: PathAnnotation.getAnnotion ()

    [ https://issues.apache.org/jira/browse/TAVERNA-846?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14624691#comment-14624691 ] 

ASF GitHub Bot commented on TAVERNA-846:
----------------------------------------

GitHub user binfalse opened a pull request:

    https://github.com/apache/incubator-taverna-language/pull/15

    fixed typo in getAnnotion and added ignore annotation

    there was a typo in `PathAnnotation.getAnnotion ()` -- renamed that
    method to `PathAnnotation.getAnnotation()` keeping the old method for
    backwards compatibility. also added the `@JsonIgnore` annotation to both
    methods to ignore them during serialisation.
    
    this should fix https://issues.apache.org/jira/browse/TAVERNA-846

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/binfalse/incubator-taverna-language master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-taverna-language/pull/15.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #15
    
----
commit 075ef0b094390aedf326283b89dd777bbe3fddcc
Author: Martin Scharm <ma...@binfalse.de>
Date:   2015-07-13T14:04:11Z

    fixed typo in getAnnotion and added ignore annotation
    
    there was a typo in `PathAnnotation.getAnnotion ()` -- renamed that
    method to `PathAnnotation.getAnnotation()` keeping the old method for
    backwards compatibility. also added the `@JsonIgnore` annotation to both
    methods to ignore them during serialisation.

----


> Typo and annotation missing: PathAnnotation.getAnnotion ()
> ----------------------------------------------------------
>
>                 Key: TAVERNA-846
>                 URL: https://issues.apache.org/jira/browse/TAVERNA-846
>             Project: Apache Taverna
>          Issue Type: Bug
>            Reporter: martin scharm
>            Assignee: Stian Soiland-Reyes
>            Priority: Minor
>
> {{getAnnotion ()}} is probably supposed to be {{getAnnotation ()}}? Moreover, this method is missing the {{@JsonIgnore}} annotation and therefore serialises to annotations such as: 
> {code:title=Bar.java|borderStyle=solid}
>   {
>     "uri" : "urn:uuid:2490cc20-d416-456a-8561-7c4411b51797",
>     "about" : "/stuff",
>     "content" : "annotations/stuff",
>     "annotion" : "urn:uuid:2490cc20-d416-456a-8561-7c4411b51797"
>   }
> {code}
> See https://github.com/apache/incubator-taverna-language/blob/d8317cc7883eba836ac2f55fd53bf07fb6325449/taverna-robundle/src/main/java/org/apache/taverna/robundle/manifest/PathAnnotation.java#L70



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)