You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/09/30 06:24:18 UTC

[GitHub] [arrow] arw2019 commented on a change in pull request #8269: ARROW-10070: [C++][Compute] Implement var and std aggregate kernel

arw2019 commented on a change in pull request #8269:
URL: https://github.com/apache/arrow/pull/8269#discussion_r497268296



##########
File path: cpp/src/arrow/compute/api_aggregate.h
##########
@@ -76,6 +76,18 @@ struct ARROW_EXPORT MinMaxOptions : public FunctionOptions {
   enum Mode null_handling = SKIP;
 };
 
+/// \brief Control Delta Degrees of Freedom (ddof) of Variance and Stddev kernel
+///
+/// The divisor used in calculations is N - ddof, where N is the number of elements.
+/// By default, ddof is zero, and population variance or stddev is returned.
+struct ARROW_EXPORT VarStdOptions : public FunctionOptions {
+  explicit VarStdOptions(int ddof = 0) : ddof(ddof) {}

Review comment:
       Naming suggestion: how about `DdofOptions`?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org