[GitHub] [geode] kirklund commented on a change in pull request #5299: GEODE-8200: enhance GfshRule to specify a working dir

[GitBox <gi...@apache.org>]

kirklund commented on a change in pull request #5299:
URL: https://github.com/apache/geode/pull/5299#discussion_r445691690



##########
File path: geode-junit/src/main/java/org/apache/geode/test/junit/rules/gfsh/GfshRule.java
##########
@@ -199,4 +220,23 @@ private void stopMembers(GfshExecution gfshExecution) {
     }
     execute(GfshScript.of(stopMemberScripts).withName("Stop-Members"));
   }
+
+  public static String startServerCommand(String name, int port, int connectedLocatorPort) {

Review comment:
       These new static methods don't really fit well in GfshRule. I think you should probably move them to two new classes (probably not a rule) named something like ServerCommandBuilder and LocatorCommandBuilder, and explode the parameters to each have their own setter type method:
   ```
   String startServerCommand = new ServerCommandBuilder()
       .withPort(port)
       .withLocator(locatorPort)
       .create(name);
   ```




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org