You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@tajo.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2014/11/03 11:15:33 UTC

[jira] [Commented] (TAJO-1149) Implement direct read of DelimitedTextFile

    [ https://issues.apache.org/jira/browse/TAJO-1149?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14194404#comment-14194404 ] 

ASF GitHub Bot commented on TAJO-1149:
--------------------------------------

Github user jinossy commented on the pull request:

    https://github.com/apache/tajo/pull/221#issuecomment-61458728
  
    I didn't change the CSVFile properties in test case, because it can test backward compatibility


> Implement direct read of DelimitedTextFile
> ------------------------------------------
>
>                 Key: TAJO-1149
>                 URL: https://issues.apache.org/jira/browse/TAJO-1149
>             Project: Tajo
>          Issue Type: Sub-task
>          Components: storage
>            Reporter: Jinho Kim
>            Assignee: Jinho Kim
>              Labels: performance
>
> If a text file is uncompressed, scanner is able to read from direct buffer
> Other cases, it read from input stream.
> This patch includes some refactoring  as follows:
> * rename properties
> ** {{csvfile.delimiter}} to {{text.delimiter}} 
> ** {{csvfile.null}} to {{text.null}}
> * Add DelimitedLineReader
> ** it will be easier to implement text-format variations.
> * Use the java Unsafe for split line and field 
> ** It will be better performance
> * Remove seekable interface
> ** We use the CSVFile to just debugging
>  



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)