[jira] [Commented] (HIVE-243) ^C breaks out of running query, but not whole CLI

["jiraposter@reviews.apache.org (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HIVE-243?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13031388#comment-13031388 ] 

jiraposter@reviews.apache.org commented on HIVE-243:
----------------------------------------------------



bq.  On 2011-04-20 17:51:59, Ning Zhang wrote:
bq.  > trunk/cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java, line 313
bq.  > <https://reviews.apache.org/r/626/diff/1/?file=16075#file16075line313>
bq.  >
bq.  >     Does this handle the case when a MapReduce job is launched and CLI got a CTL+C? Currently we have a JVM shutdownHook defined in HadoopJobExecHelper.java to kill the MR job before the JVM shut down (the old behavior when hitting a CTL+C). 
bq.  >     
bq.  >     Here if we don't shut down the JVM, you should do the same thing to kill the running MR jobs.

Sorry for the delayed response, I didn't get email notification for the comment. Let me try to hookup the running jobs kill to the ctrl+c handler. I don't think it will do it with the current code as it will prevent the shutdown hook of being called.


- georgedj


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/626/#review505
-----------------------------------------------------------


On 2011-05-10 21:25:03, georgedj wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/626/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-05-10 21:25:03)
bq.  
bq.  
bq.  Review request for hive.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Fixed by adding INT signal hander that interrupts the CLI thread. The CLI thread gets InterruptedException and it stops the current command.
bq.  
bq.  
bq.  This addresses bug HIVE-243.
bq.      https://issues.apache.org/jira/browse/HIVE-243
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    trunk/cli/src/java/org/apache/hadoop/hive/cli/CliDriver.java 1100312 
bq.    trunk/common/src/java/org/apache/hadoop/hive/common/HiveInterruptCallback.java PRE-CREATION 
bq.    trunk/common/src/java/org/apache/hadoop/hive/common/HiveInterruptUtils.java PRE-CREATION 
bq.    trunk/metastore/src/java/org/apache/hadoop/hive/metastore/ObjectStore.java 1100312 
bq.    trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/HadoopJobExecHelper.java 1100312 
bq.    trunk/ql/src/java/org/apache/hadoop/hive/ql/exec/Utilities.java 1100312 
bq.  
bq.  Diff: https://reviews.apache.org/r/626/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  Manual test Ctrl+C on bunch of command (show tables, select, etc)
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  georgedj
bq.  
bq.



> ^C breaks out of running query, but not whole CLI
> -------------------------------------------------
>
>                 Key: HIVE-243
>                 URL: https://issues.apache.org/jira/browse/HIVE-243
>             Project: Hive
>          Issue Type: Wish
>          Components: Query Processor
>    Affects Versions: 0.8.0
>            Reporter: Adam Kramer
>
> It would be lovely if, when I know a query is bad, I could just ^C out of it. I can do that now, but the whole CLI quits.
> It'd be quite nice if it took an extra ^C to break the CLI, or if there was some control character to break out of a query without breaking out of the CLI.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira