You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jonathan Ellis (JIRA)" <ji...@apache.org> on 2010/01/19 22:29:56 UTC

[jira] Created: (CASSANDRA-719) fix failing CompactionsPurgeTest

fix failing CompactionsPurgeTest
--------------------------------

                 Key: CASSANDRA-719
                 URL: https://issues.apache.org/jira/browse/CASSANDRA-719
             Project: Cassandra
          Issue Type: Bug
    Affects Versions: 0.6
            Reporter: Jonathan Ellis
             Fix For: 0.6




-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-719) fix failing CompactionsPurgeTest

Posted by "Chris Goffinet (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12803549#action_12803549 ] 

Chris Goffinet commented on CASSANDRA-719:
------------------------------------------

+1

> fix failing CompactionsPurgeTest
> --------------------------------
>
>                 Key: CASSANDRA-719
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-719
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 0.6
>            Reporter: Jonathan Ellis
>             Fix For: 0.6
>
>         Attachments: 719.txt
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-719) fix failing CompactionsPurgeTest

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12802479#action_12802479 ] 

Jonathan Ellis commented on CASSANDRA-719:
------------------------------------------

(see CASSANDRA-710 for genesis.  Note that this test has been silently broken for we don't know how long, something in the other tests in CompactionsTest were covering it up.)

> fix failing CompactionsPurgeTest
> --------------------------------
>
>                 Key: CASSANDRA-719
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-719
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 0.6
>            Reporter: Jonathan Ellis
>             Fix For: 0.6
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Resolved: (CASSANDRA-719) fix failing CompactionsPurgeTest

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis resolved CASSANDRA-719.
--------------------------------------

    Resolution: Fixed
      Assignee: Jonathan Ellis

committed

> fix failing CompactionsPurgeTest
> --------------------------------
>
>                 Key: CASSANDRA-719
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-719
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 0.6
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>             Fix For: 0.6
>
>         Attachments: 719.txt
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (CASSANDRA-719) fix failing CompactionsPurgeTest

Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/CASSANDRA-719?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Jonathan Ellis updated CASSANDRA-719:
-------------------------------------

    Attachment: 719.txt

invalidate cache after compaction in test so we read what's in the new sstable instead of the cache

alternatively we could fix this by making compaction invalidate the cache, but i think this is a bad idea; the system is designed so that to the client it makes no difference if the tombstones are GC'd or not since we hide them, so there is no hurry to uncache things.  And compaction (when we are doing a lot of extra io) is a particularly bad time to throw away the whole cache.  Just leave it to be invalidated eventually through natural causes.

> fix failing CompactionsPurgeTest
> --------------------------------
>
>                 Key: CASSANDRA-719
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-719
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 0.6
>            Reporter: Jonathan Ellis
>             Fix For: 0.6
>
>         Attachments: 719.txt
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (CASSANDRA-719) fix failing CompactionsPurgeTest

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/CASSANDRA-719?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12803685#action_12803685 ] 

Hudson commented on CASSANDRA-719:
----------------------------------

Integrated in Cassandra #331 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/331/])
    invalidate cache after compaction so we read what's in the new sstable instead of the cache
patch by jbellis; reviewed by goffinet for 


> fix failing CompactionsPurgeTest
> --------------------------------
>
>                 Key: CASSANDRA-719
>                 URL: https://issues.apache.org/jira/browse/CASSANDRA-719
>             Project: Cassandra
>          Issue Type: Bug
>    Affects Versions: 0.6
>            Reporter: Jonathan Ellis
>            Assignee: Jonathan Ellis
>             Fix For: 0.6
>
>         Attachments: 719.txt
>
>


-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.