You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@iceberg.apache.org by GitBox <gi...@apache.org> on 2021/07/22 15:23:44 UTC

[GitHub] [iceberg] rdblue commented on pull request #2849: Fix bucketing of strings with non-BMP characters

rdblue commented on pull request #2849:
URL: https://github.com/apache/iceberg/pull/2849#issuecomment-885001482


   Looks good to me. I agree with the choice to detect cases where `hashString` can't be used since converting the string to bytes will allocate a new `ByteBuffer` and copy into it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org