[GitHub] [arrow-rs] paddyhoran commented on a change in pull request #1146: Implement SIMD comparison operations for types with less than 4 lanes (i128)

[GitBox <gi...@apache.org>]

paddyhoran commented on a change in pull request #1146:
URL: https://github.com/apache/arrow-rs/pull/1146#discussion_r781201456



##########
File path: arrow/src/compute/kernels/comparison.rs
##########
@@ -1471,53 +1471,65 @@ where
 
     let null_bit_buffer = combine_option_bitmap(left.data_ref(), right.data_ref(), len)?;
 
+    // we process the data in chunks to that each iteration results in one u64 of comparison result bits

Review comment:
       ```suggestion
       // we process the data in chunks so that each iteration results in one u64 of comparison result bits
   ```

##########
File path: arrow/src/compute/kernels/comparison.rs
##########
@@ -1551,16 +1563,20 @@ where
 
     let len = left.len();
 
+    // we process the data in chunks to that each iteration results in one u64 of comparison result bits

Review comment:
       ```suggestion
       // we process the data in chunks so that each iteration results in one u64 of comparison result bits
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org