[GitHub] [airflow] ephraimbuddy commented on a change in pull request #14366: Add CollectionInfo in all Collections that have total_entries

[GitBox <gi...@apache.org>]

ephraimbuddy commented on a change in pull request #14366:
URL: https://github.com/apache/airflow/pull/14366#discussion_r584202432



##########
File path: airflow/api_connexion/openapi/v1.yaml
##########
@@ -1419,12 +1397,15 @@ components:
 
     ConnectionCollection:
       type: object
-      description: Connections
-      properties:
-        connections:
-          type: array
-          items:
-            $ref: '#/components/schemas/ConnectionCollectionItem'
+      description: Collection of connections.
+      allOf:
+       - type: object
+         properties:
+           connections:
+            type: array

Review comment:
       You have linting errors in ConnectionCollection. Can you install pre-commit so you can find issues locally before committing. https://github.com/apache/airflow/blob/master/STATIC_CODE_CHECKS.rst#pre-commit-hooks.
   
   This should work:
   ```
       ConnectionCollection:
         type: object
         description: Collection of connections.
         allOf:
           - type: object
             properties:
               connections:
                 type: array
                 items:
                   $ref: '#/components/schemas/ConnectionCollectionItem'
           - $ref: '#/components/schemas/CollectionInfo'
   ```
   If you accept, I can push a fix for you but first try and see if you are able to resolve it. Thanks




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org