You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@streampipes.apache.org by GitBox <gi...@apache.org> on 2022/10/24 13:58:02 UTC
[GitHub] [incubator-streampipes] obermeier opened a new pull request, #126: [STREAMPIPES-604] Add NGINX volume to compose deplyment
obermeier opened a new pull request, #126:
URL: https://github.com/apache/incubator-streampipes/pull/126
Sometimes it is usefull to change the configururation of the NGINX-Proxy.
E.g. to provide REST-Endpoints on a different port
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampipes] tenthe commented on pull request #126: [STREAMPIPES-604] Add NGINX volume to compose deployment
Posted by GitBox <gi...@apache.org>.
tenthe commented on PR #126:
URL: https://github.com/apache/incubator-streampipes/pull/126#issuecomment-1292158856
When users want to use SSL, they also have to change the nginx configurations in the docker-compose file, as described in [Documentation](https://streampipes.apache.org/docs/docs/deploy-use-ssl.html).
Do we have to consider or adjust anything here with the new volume mapping?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampipes] dominikriemer commented on pull request #126: [STREAMPIPES-604] Add NGINX volume to compose deployment
Posted by GitBox <gi...@apache.org>.
dominikriemer commented on PR #126:
URL: https://github.com/apache/incubator-streampipes/pull/126#issuecomment-1291084312
Cool! Should we also add the volume to the docker-compose files in installer/compose?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampipes] obermeier commented on pull request #126: [STREAMPIPES-604] Add NGINX volume to compose deployment
Posted by GitBox <gi...@apache.org>.
obermeier commented on PR #126:
URL: https://github.com/apache/incubator-streampipes/pull/126#issuecomment-1293732960
> Good question, I am not sure. The location of the certificate is defined in /ui/nginx_config/ssl.conf. I guess we can just change it there if we want to use two different volumes. What do you think?
Yes I like this idear
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampipes] tenthe commented on pull request #126: [STREAMPIPES-604] Add NGINX volume to compose deployment
Posted by GitBox <gi...@apache.org>.
tenthe commented on PR #126:
URL: https://github.com/apache/incubator-streampipes/pull/126#issuecomment-1292487115
Good question, I am not sure.
The location of the certificate is defined in /ui/nginx_config/ssl.conf.
I guess we can just change it there if we want to use two different volumes.
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampipes] obermeier commented on pull request #126: [STREAMPIPES-604] Add NGINX volume to compose deployment
Posted by GitBox <gi...@apache.org>.
obermeier commented on PR #126:
URL: https://github.com/apache/incubator-streampipes/pull/126#issuecomment-1292251063
Is it a good solution to store the configuration and certificates in the same volume?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampipes] obermeier commented on pull request #126: [STREAMPIPES-604] Add NGINX volume to compose deployment
Posted by GitBox <gi...@apache.org>.
obermeier commented on PR #126:
URL: https://github.com/apache/incubator-streampipes/pull/126#issuecomment-1292197140
I think the the Documentation is still valid.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampipes] obermeier commented on pull request #126: [STREAMPIPES-604] Add NGINX volume to compose deployment
Posted by GitBox <gi...@apache.org>.
obermeier commented on PR #126:
URL: https://github.com/apache/incubator-streampipes/pull/126#issuecomment-1292150043
> Cool! Should we also add the volume to the docker-compose files in installer/compose?
In my eyes this is a very good idea.
In the k8s deployment descriptor too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampipes] obermeier commented on pull request #126: [STREAMPIPES-604] Add NGINX volume to compose deployment
Posted by GitBox <gi...@apache.org>.
obermeier commented on PR #126:
URL: https://github.com/apache/incubator-streampipes/pull/126#issuecomment-1293740191
I realized that the volumes in k8s overrides the files from the docker image. (I should have known it.)
In this case the configuration must be placed to the volume via ConfigMap, SideCar, copy from ...
Since there is a good default configuration and adding a volume is easy this task could be left to the user!?
If he wants to change the configuration and persist this changes.
For this reason I removed the volume for the nginx configuration
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-streampipes] dominikriemer merged pull request #126: [STREAMPIPES-604] Add NGINX volume to compose deployment
Posted by GitBox <gi...@apache.org>.
dominikriemer merged PR #126:
URL: https://github.com/apache/incubator-streampipes/pull/126
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@streampipes.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org