[jira] [Comment Edited] (HBASE-21208) Bytes#toShort doesn't work without unsafe

["Chia-Ping Tsai (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HBASE-21208?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16619241#comment-16619241 ] 

Chia-Ping Tsai edited comment on HBASE-21208 at 9/18/18 3:07 PM:
-----------------------------------------------------------------

[~yuzhihong@gmail.com] Thanks for your reviews.

01
- fix checkstyle
- add a bit change to hbase-server so as to trigger full QA


was (Author: chia7712):
[~yuzhihong@gmail.com] Thanks for you reviews.

01
- fix checkstyle
- add a bit change to hbase-server so as to trigger full QA

> Bytes#toShort doesn't work without unsafe
> -----------------------------------------
>
>                 Key: HBASE-21208
>                 URL: https://issues.apache.org/jira/browse/HBASE-21208
>             Project: HBase
>          Issue Type: Bug
>            Reporter: Chia-Ping Tsai
>            Assignee: Chia-Ping Tsai
>            Priority: Critical
>             Fix For: 2.2.0, 2.1.1, 2.0.3
>
>         Attachments: HBASE-21208.v0.patch, HBASE-21208.v1.patch
>
>
> seems we put the brackets in the wrong place.
> {code}
>       short n = 0;
>       n = (short) ((n ^ bytes[offset]) & 0xFF);
>       n = (short) (n << 8);
>       n = (short) ((n ^ bytes[offset+1]) & 0xFF);   // this one
>       return n;
> {code}



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)