You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/02/09 06:09:49 UTC

[GitHub] [apisix-website] starsz opened a new pull request #172: docs: remove redundant step in release-guide.md

starsz opened a new pull request #172:
URL: https://github.com/apache/apisix-website/pull/172


   Fixes: #[Add issue number here]
   
   Changes:
   
   Hello, now the apisix and apisix-dashboard project's `Makefile` will exclude the `.git` file.
   So I think we don't do this step in the release-guide.
   
   See: https://github.com/apache/apisix-dashboard/blob/fda123c28dda7e4f4ae5d649b286ffcaebc568ae/Makefile#L114
   See: https://github.com/apache/apisix/blob/c895cdf4ff008c13dec8197e9f0a0407be144517/Makefile#L226
   
   Screenshots of the change:
   
   <!-- Add screenshots depicting the changes. -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] nic-chen commented on pull request #172: docs: remove redundant step in release-guide.md

Posted by GitBox <gi...@apache.org>.
nic-chen commented on pull request #172:
URL: https://github.com/apache/apisix-website/pull/172#issuecomment-775843634


   > It is possible that the user may not pack through the makefile, so to be on the safe side I don't think we should remove line211-213. cc @nic-chen 
   
   agree with you,we could keep them


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] tokers merged pull request #172: docs: remove redundant step in release-guide.md

Posted by GitBox <gi...@apache.org>.
tokers merged pull request #172:
URL: https://github.com/apache/apisix-website/pull/172


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [apisix-website] starsz commented on pull request #172: docs: remove redundant step in release-guide.md

Posted by GitBox <gi...@apache.org>.
starsz commented on pull request #172:
URL: https://github.com/apache/apisix-website/pull/172#issuecomment-775984470


   > It is possible that the user may not pack through the makefile, so to be on the safe side I don't think we should remove line211-213. cc @nic-chen
   
   Because the line 214 ~ 215 tell us to use`make release`.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org