You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@seatunnel.apache.org by GitBox <gi...@apache.org> on 2022/01/10 07:00:48 UTC
[GitHub] [incubator-seatunnel] felix-thinkingdata opened a new pull request #993: [Feature][seatunnel-examples] spark local environment run quickly and debug locally developed code easily
felix-thinkingdata opened a new pull request #993:
URL: https://github.com/apache/incubator-seatunnel/pull/993
this closes https://github.com/apache/incubator-seatunnel/issues/961
## Purpose of this pull request
spark local environment run quickly and debug locally developed code easily
## Check list
* [ ] Code changed are covered with tests, or it does not need tests for reason:
* [ ] If necessary, please update the documentation to describe the new feature. https://github.com/apache/incubator-seatunnel/tree/dev/docs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] leo65535 commented on a change in pull request #993: [Feature][seatunnel-examples] spark local environment run quickly and debug locally developed code easily
Posted by GitBox <gi...@apache.org>.
leo65535 commented on a change in pull request #993:
URL: https://github.com/apache/incubator-seatunnel/pull/993#discussion_r780957507
##########
File path: seatunnel-examples/seatunnel-spark-examples/src/main/java/org/apache/seatunnel/test/spark/LocalTest.java
##########
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.seatunnel.test.spark;
Review comment:
> ok ,Let me modify that. Should I revise flink's example together
yeah.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] felix-thinkingdata commented on a change in pull request #993: [Feature][seatunnel-examples] spark local environment run quickly and debug locally developed code easily
Posted by GitBox <gi...@apache.org>.
felix-thinkingdata commented on a change in pull request #993:
URL: https://github.com/apache/incubator-seatunnel/pull/993#discussion_r781019667
##########
File path: seatunnel-examples/seatunnel-spark-examples/src/main/java/org/apache/seatunnel/test/spark/LocalTest.java
##########
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.seatunnel.test.spark;
Review comment:
> > ok ,Let me modify that. Should I revise flink's example together
>
> yeah.
done.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] CalvinKirs merged pull request #993: [Feature][seatunnel-examples] spark local environment run quickly and debug locally developed code easily
Posted by GitBox <gi...@apache.org>.
CalvinKirs merged pull request #993:
URL: https://github.com/apache/incubator-seatunnel/pull/993
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] leo65535 commented on a change in pull request #993: [Feature][seatunnel-examples] spark local environment run quickly and debug locally developed code easily
Posted by GitBox <gi...@apache.org>.
leo65535 commented on a change in pull request #993:
URL: https://github.com/apache/incubator-seatunnel/pull/993#discussion_r780940848
##########
File path: seatunnel-examples/seatunnel-spark-examples/src/main/java/org/apache/seatunnel/test/spark/LocalTest.java
##########
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.seatunnel.test.spark;
Review comment:
hi @felix-thinkingdata,
- the package name `package org.apache.seatunnel.example.spark;` is better
- the class name `LocalSparkExample` is better
Can you help to rename the `flink` example at this patch?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-seatunnel] felix-thinkingdata commented on a change in pull request #993: [Feature][seatunnel-examples] spark local environment run quickly and debug locally developed code easily
Posted by GitBox <gi...@apache.org>.
felix-thinkingdata commented on a change in pull request #993:
URL: https://github.com/apache/incubator-seatunnel/pull/993#discussion_r780957139
##########
File path: seatunnel-examples/seatunnel-spark-examples/src/main/java/org/apache/seatunnel/test/spark/LocalTest.java
##########
@@ -0,0 +1,38 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.seatunnel.test.spark;
Review comment:
>
ok ,Let me modify that. Should I revise flink's example together
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@seatunnel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org