[GitHub] [iceberg] flyrain commented on a change in pull request #2452: Dedup files list generated in BaseSparkAction

[GitBox <gi...@apache.org>]

flyrain commented on a change in pull request #2452:
URL: https://github.com/apache/iceberg/pull/2452#discussion_r615082111



##########
File path: spark/src/main/java/org/apache/iceberg/spark/actions/BaseSparkAction.java
##########
@@ -159,7 +159,7 @@ protected Table newStaticTable(TableMetadata metadata, FileIO io) {
         .repartition(spark.sessionState().conf().numShufflePartitions()) // avoid adaptive execution combining tasks
         .as(Encoders.bean(ManifestFileBean.class));
 
-    return allManifests.flatMap(new ReadManifest(ioBroadcast), Encoders.STRING()).toDF("file_path");
+    return allManifests.flatMap(new ReadManifest(ioBroadcast), Encoders.STRING()).toDF("file_path").distinct();

Review comment:
       What's the downside of additional shuffle? It should be OK here if its overhead is acceptable.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org