[GitHub] zhaijack commented on a change in pull request #1996: Cpp client: add multiTopicsConsumer

[GitBox <gi...@apache.org>]

zhaijack commented on a change in pull request #1996: Cpp client: add multiTopicsConsumer
URL: https://github.com/apache/incubator-pulsar/pull/1996#discussion_r197128237
 
 

 ##########
 File path: pulsar-client-cpp/include/pulsar/MessageId.h
 ##########
 @@ -34,6 +34,16 @@ class MessageId {
     MessageId& operator=(const MessageId&);
     MessageId();
 
+    /**
+     * Only for MultiTopicsConsumer to set a valid topicName
+     */
+    void setTopicName(std::string topicName);
+
+    /**
+     * Only for MultiTopicsConsumer to get a valid topicName
+     */
+    std::string& getTopicName() const;
 
 Review comment:
   Thanks, Seems need it. in acknowledgeAsync, we use getTopicName(), then use the topicName to find which sub-consumer to do the ack. Also, in UnAckedMessageTracker to remove MessageIds that belongs to a sub-consumer.
   will move this into private.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services