[GitHub] shaofengshi commented on a change in pull request #195: KYLIN-3446 Connect to HBase out of Spark

[GitBox <gi...@apache.org>]

shaofengshi commented on a change in pull request #195: KYLIN-3446 Connect to HBase out of Spark
URL: https://github.com/apache/kylin/pull/195#discussion_r211134185
 
 

 ##########
 File path: storage-hbase/src/main/java/org/apache/kylin/storage/hbase/steps/CreateHTableJob.java
 ##########
 @@ -300,7 +339,8 @@ protected static void saveHFileSplits(final List<HashMap<Long, Double>> innerReg
                     logger.info(String.format("Region %d's hfile %d size is %.2f mb", i, j, accumulatedSize));
                     byte[] split = new byte[RowConstants.ROWKEY_SHARD_AND_CUBOID_LEN];
                     BytesUtil.writeUnsigned(i, split, 0, RowConstants.ROWKEY_SHARDID_LEN);
-                    System.arraycopy(Bytes.toBytes(cuboid), 0, split, RowConstants.ROWKEY_SHARDID_LEN, RowConstants.ROWKEY_CUBOIDID_LEN);
+                    System.arraycopy(Bytes.toBytes(cuboid), 0, split, RowConstants.ROWKEY_SHARDID_LEN,
 
 Review comment:
   It seems your code formatter is wrong, which causes some unnecessary diffs.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services