You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sling.apache.org by Julian Sedding <js...@gmail.com> on 2015/12/04 12:39:46 UTC
Failing Test Cases
Hi all,
It seems to me that the following two tests fail since the Felix HTTP
Service was updated in https://svn.apache.org/r1717072. The first
build for which they failed failed was #2112 [0] on Java 8 and #2827
[1] on Java 7
- org.apache.sling.launchpad.webapp.integrationtest.WebDavDoubleSlashTest.testEmptyWorkspace
- org.apache.sling.launchpad.webapp.integrationtest.servlets.resolution.RequestObjectTest.testRequestPathInfo
Regards
Julian
[0] https://builds.apache.org/job/sling-trunk-1.8/2112/
[1] https://builds.apache.org/job/sling-trunk-1.7/2827/
Re: Failing Test Cases
Posted by Julian Sedding <js...@gmail.com>.
Thanks Carsten!
On Monday, December 7, 2015, Carsten Ziegeler <cz...@apache.org> wrote:
> Julian Sedding wrote
> > I have created SLING-5353[0] to track the failure of
> > WebDavDoubleSlashTest.testEmptyWorkspace and changed the test case so
> > that the response body is logged in case of a failure (see ticket for
> > output I have captured and formatted).
> >
> > Unfortunately I know too little about the scenario, so I cannot make
> > much sense from it.
> >
> Previous Http Jetty version was using a method which compacts "a//b" to
> "a/b". That's why we started getting the 404.
> This code is not executed anymore, and a//b stays like this - which
> gives us the old behaviour of Http Jetty 2.x.
>
> Jetty standalone treats "a//b" as a different url as "a/b", so it seems
> the temporary behaviour of the last Http Jetty versions was
> wrong/unexpected.
>
> I'll fix the test case
>
> Carsten
> --
> Carsten Ziegeler
> Adobe Research Switzerland
> cziegeler@apache.org <javascript:;>
>
Re: Failing Test Cases
Posted by Carsten Ziegeler <cz...@apache.org>.
Julian Sedding wrote
> I have created SLING-5353[0] to track the failure of
> WebDavDoubleSlashTest.testEmptyWorkspace and changed the test case so
> that the response body is logged in case of a failure (see ticket for
> output I have captured and formatted).
>
> Unfortunately I know too little about the scenario, so I cannot make
> much sense from it.
>
Previous Http Jetty version was using a method which compacts "a//b" to
"a/b". That's why we started getting the 404.
This code is not executed anymore, and a//b stays like this - which
gives us the old behaviour of Http Jetty 2.x.
Jetty standalone treats "a//b" as a different url as "a/b", so it seems
the temporary behaviour of the last Http Jetty versions was
wrong/unexpected.
I'll fix the test case
Carsten
--
Carsten Ziegeler
Adobe Research Switzerland
cziegeler@apache.org
Re: Failing Test Cases
Posted by Julian Sedding <js...@gmail.com>.
I have created SLING-5353[0] to track the failure of
WebDavDoubleSlashTest.testEmptyWorkspace and changed the test case so
that the response body is logged in case of a failure (see ticket for
output I have captured and formatted).
Unfortunately I know too little about the scenario, so I cannot make
much sense from it.
Regards
Julian
[0] https://issues.apache.org/jira/browse/SLING-5353
On Sat, Dec 5, 2015 at 2:15 PM, Carsten Ziegeler <cz...@apache.org> wrote:
> Julian Sedding wrote
>> Hi all,
>>
>> It seems to me that the following two tests fail since the Felix HTTP
>> Service was updated in https://svn.apache.org/r1717072. The first
>> build for which they failed failed was #2112 [0] on Java 8 and #2827
>> [1] on Java 7
>>
>> - org.apache.sling.launchpad.webapp.integrationtest.WebDavDoubleSlashTest.testEmptyWorkspace
>
> Not sure what's going on there, a status code of 207 looks interesting...
>
>> - org.apache.sling.launchpad.webapp.integrationtest.servlets.resolution.RequestObjectTest.testRequestPathInfo
>
> Yes, we fixed the requestUri handling in the jetty implementation and it
> now correctly returns the raw uri including path parameters.
> I've adjusted that test.
>
> Carsten
>
>
> --
> Carsten Ziegeler
> Adobe Research Switzerland
> cziegeler@apache.org
Re: Failing Test Cases
Posted by Carsten Ziegeler <cz...@apache.org>.
Julian Sedding wrote
> Hi all,
>
> It seems to me that the following two tests fail since the Felix HTTP
> Service was updated in https://svn.apache.org/r1717072. The first
> build for which they failed failed was #2112 [0] on Java 8 and #2827
> [1] on Java 7
>
> - org.apache.sling.launchpad.webapp.integrationtest.WebDavDoubleSlashTest.testEmptyWorkspace
Not sure what's going on there, a status code of 207 looks interesting...
> - org.apache.sling.launchpad.webapp.integrationtest.servlets.resolution.RequestObjectTest.testRequestPathInfo
Yes, we fixed the requestUri handling in the jetty implementation and it
now correctly returns the raw uri including path parameters.
I've adjusted that test.
Carsten
--
Carsten Ziegeler
Adobe Research Switzerland
cziegeler@apache.org