You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2022/07/01 05:40:11 UTC

[GitHub] [druid] clintropolis commented on a diff in pull request #12727: fix DruidSchema issue where datasources with no segments can become stuck in tables list indefinitely

clintropolis commented on code in PR #12727:
URL: https://github.com/apache/druid/pull/12727#discussion_r911629886


##########
integration-tests/src/test/java/org/apache/druid/tests/query/ITBroadcastJoinQueryTest.java:
##########
@@ -127,9 +130,22 @@ public void testBroadcastJoin() throws Exception
           replaceJoinTemplate(getResourceAsString(BROADCAST_JOIN_QUERIES_RESOURCE), BROADCAST_JOIN_DATASOURCE)
       );
     }
+
     finally {
       closer.close();
 
+      coordinator.unloadSegmentsForDataSource(BROADCAST_JOIN_DATASOURCE);

Review Comment:
   ah yeah, i forgot to look closer at what unloader was doing, i just added these changes initially when i was thrashing around trying to find why stuff was failing and on the surface didn't seem to be quite the same, but see now that this is repeating a subset of what unloader was doing, so have removed.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org