You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kafka.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2016/04/08 00:43:25 UTC
[jira] [Commented] (KAFKA-3526) REST APIs return object
representation instead of string for config values, default values and
recommended values
[ https://issues.apache.org/jira/browse/KAFKA-3526?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15231271#comment-15231271 ]
ASF GitHub Bot commented on KAFKA-3526:
---------------------------------------
GitHub user Ishiihara opened a pull request:
https://github.com/apache/kafka/pull/1200
KAFKA-3526: Return string instead of object in ConfigKeyInfo and ConfigValueInfo
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/Ishiihara/kafka config-string
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/kafka/pull/1200.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1200
----
commit 0a49d1df772b5810004c2c826a7dfb075d17db8b
Author: Liquan Pei <li...@gmail.com>
Date: 2016-04-07T22:19:53Z
Return string instead of object in ConfigKeyInfo and ConfigValueInfo
----
> REST APIs return object representation instead of string for config values, default values and recommended values
> ------------------------------------------------------------------------------------------------------------------
>
> Key: KAFKA-3526
> URL: https://issues.apache.org/jira/browse/KAFKA-3526
> Project: Kafka
> Issue Type: Bug
> Components: KafkaConnect
> Affects Versions: 0.10.0.0
> Reporter: Liquan Pei
> Assignee: Liquan Pei
> Fix For: 0.11.0.0
>
> Original Estimate: 24h
> Remaining Estimate: 24h
>
> In the response of
> {code}
> PUT /connector-plugins/{name}/config/validate
> {code}
> The value.value, value.recommended_values and definition.default_value (If the ConfigKey is not String type) are serialized by Jackson to something other than strings.
> We actually expect the values to be strings, and this should mirror the current requirements of submitting configs which is that the config is a Map<String, String>.
> This can be fixed by adding ConfigDef support for converting values to strings, corresponding to all the parse methods, and then making sure all these outputs of values have type String instead of Object.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)