You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Tim Armstrong (Code Review)" <ge...@cloudera.org> on 2019/01/30 10:46:15 UTC

[Impala-ASF-CR] IMPALA-8146: Remove make {debug,release,asan}.sh 

Tim Armstrong has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12306


Change subject: IMPALA-8146: Remove make_{debug,release,asan}.sh
......................................................................

IMPALA-8146: Remove make_{debug,release,asan}.sh

Change-Id: Iac997917463b871769112834835cc3f99cff5954
---
D bin/make_asan.sh
D bin/make_debug.sh
D bin/make_release.sh
3 files changed, 0 insertions(+), 60 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/06/12306/1
-- 
To view, visit http://gerrit.cloudera.org:8080/12306
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Iac997917463b871769112834835cc3f99cff5954
Gerrit-Change-Number: 12306
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>

[Impala-ASF-CR] IMPALA-8146: Remove make {debug,release,asan}.sh

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12306 )

Change subject: IMPALA-8146: Remove make_{debug,release,asan}.sh
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/12306
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac997917463b871769112834835cc3f99cff5954
Gerrit-Change-Number: 12306
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 30 Jan 2019 19:55:07 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8146: Remove make {debug,release,asan}.sh

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12306 )

Change subject: IMPALA-8146: Remove make_{debug,release,asan}.sh
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3691/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/12306
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac997917463b871769112834835cc3f99cff5954
Gerrit-Change-Number: 12306
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 30 Jan 2019 19:55:08 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8146: Remove make {debug,release,asan}.sh

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/12306 )

Change subject: IMPALA-8146: Remove make_{debug,release,asan}.sh
......................................................................


Patch Set 1: Code-Review+1


-- 
To view, visit http://gerrit.cloudera.org:8080/12306
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac997917463b871769112834835cc3f99cff5954
Gerrit-Change-Number: 12306
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 30 Jan 2019 12:36:24 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8146: Remove make {debug,release,asan}.sh

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12306 )

Change subject: IMPALA-8146: Remove make_{debug,release,asan}.sh
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/1931/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/12306
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac997917463b871769112834835cc3f99cff5954
Gerrit-Change-Number: 12306
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 30 Jan 2019 18:48:11 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8146: Remove make {debug,release,asan}.sh

Posted by "Philip Zeyliger (Code Review)" <ge...@cloudera.org>.
Philip Zeyliger has posted comments on this change. ( http://gerrit.cloudera.org:8080/12306 )

Change subject: IMPALA-8146: Remove make_{debug,release,asan}.sh
......................................................................


Patch Set 1: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/12306
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac997917463b871769112834835cc3f99cff5954
Gerrit-Change-Number: 12306
Gerrit-PatchSet: 1
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 30 Jan 2019 18:23:51 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8146: Remove make {debug,release,asan}.sh

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12306 )

Change subject: IMPALA-8146: Remove make_{debug,release,asan}.sh
......................................................................


Patch Set 2: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/12306
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Iac997917463b871769112834835cc3f99cff5954
Gerrit-Change-Number: 12306
Gerrit-PatchSet: 2
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 30 Jan 2019 23:42:04 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-8146: Remove make {debug,release,asan}.sh

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12306 )

Change subject: IMPALA-8146: Remove make_{debug,release,asan}.sh
......................................................................

IMPALA-8146: Remove make_{debug,release,asan}.sh

Change-Id: Iac997917463b871769112834835cc3f99cff5954
Reviewed-on: http://gerrit.cloudera.org:8080/12306
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
D bin/make_asan.sh
D bin/make_debug.sh
D bin/make_release.sh
3 files changed, 0 insertions(+), 60 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/12306
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Iac997917463b871769112834835cc3f99cff5954
Gerrit-Change-Number: 12306
Gerrit-PatchSet: 3
Gerrit-Owner: Tim Armstrong <ta...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Philip Zeyliger <ph...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>