You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2022/07/26 18:09:56 UTC

[GitHub] [airflow] fritz-astronomer commented on issue #25317: `postgres://` vs `postgresql://` inconsistency

fritz-astronomer commented on issue #25317:
URL: https://github.com/apache/airflow/issues/25317#issuecomment-1195817001

   That being said - I'm not sure what to fix
   
   * We wouldn't change `conn_type` to be `postgresql` - that seems like an unnecessarily large/breaking change, and `postgres` is a perfectly valid `conn_type`
   * We wouldn't remove `postgresql://` in `PostgresHook.get_uri` - as it's required and correct for SQLAlchemy
   * we can't add the `get_uri` fix to `BaseHook`, because it doesn't have the method


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org