You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jackrabbit.apache.org by "angela (JIRA)" <ji...@apache.org> on 2008/01/10 15:22:34 UTC
[jira] Created: (JCR-1306) Reduce number of different
repository.xml present with jackrabbit-core
Reduce number of different repository.xml present with jackrabbit-core
----------------------------------------------------------------------
Key: JCR-1306
URL: https://issues.apache.org/jira/browse/JCR-1306
Project: Jackrabbit
Issue Type: Improvement
Components: config
Reporter: angela
Priority: Minor
while taking a look at the repository configuration and the related test-cases, i saw that there are quite some repository.xml files around... which i think is a bit confusion and probably hard to maintain once we make
changes to the config.
i would to suggest to consolidate that and - if possible - get rid of some of them.
if we can't i would suggest to put some comment in every of the different configuration files indicating
what they are used for.
from what i've seen so far (still missing complete overview)
1) http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/main/config/repository.xml
Current comment: <!-- Example Repository Configuration File -->
Usage: ??
2) http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/main/resources/org/apache/jackrabbit/core/test-repository.xml
current comment: -
Used as repository configuration in org.apache.jackrabbit.core.TestRepository.java
3) http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/main/resources/org/apache/jackrabbit/core/repository.xml
current comment: <!-- Example Repository Configuration File -->
Used by org.apache.jackrabbit.core.config.RepositoryConfigTest.java in order to create another repository.xml
under target/test-repository.xml. a bit confusing given the fact, that a test-repository.xml exists as well. I would
suggest to rename the REPOSITORY_XML constant in RepositoryConfigTest.
4) http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/test/repository/repository.xml
current comment: <!-- Example Repository Configuration File -->
Usage: i assume, that is the one referenced in test/resources/repositoryStubImpl.properties
5) http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/test/resources/org/apache/jackrabbit/core/config/repository.xml
current comment: <!-- Example Repository Configuration File -->
Usage: ??
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (JCR-1306) Reduce number of different
repository.xml present with jackrabbit-core
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jukka Zitting updated JCR-1306:
-------------------------------
Component/s: jackrabbit-core
Fix Version/s: 1.5.0
> Reduce number of different repository.xml present with jackrabbit-core
> ----------------------------------------------------------------------
>
> Key: JCR-1306
> URL: https://issues.apache.org/jira/browse/JCR-1306
> Project: Jackrabbit
> Issue Type: Improvement
> Components: config, jackrabbit-core
> Reporter: angela
> Assignee: angela
> Priority: Minor
> Fix For: 1.5.0
>
>
> while taking a look at the repository configuration and the related test-cases, i saw that there are quite some repository.xml files around... which i think is a bit confusion and probably hard to maintain once we make
> changes to the config.
> i would to suggest to consolidate that and - if possible - get rid of some of them.
> if we can't i would suggest to put some comment in every of the different configuration files indicating
> what they are used for.
> from what i've seen so far (still missing complete overview)
> 1) http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/main/config/repository.xml
> Current comment: <!-- Example Repository Configuration File -->
> Usage: ??
> 2) http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/main/resources/org/apache/jackrabbit/core/test-repository.xml
> current comment: -
> Used as repository configuration in org.apache.jackrabbit.core.TestRepository.java
>
> 3) http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/main/resources/org/apache/jackrabbit/core/repository.xml
>
> current comment: <!-- Example Repository Configuration File -->
> Used by org.apache.jackrabbit.core.config.RepositoryConfigTest.java in order to create another repository.xml
> under target/test-repository.xml. a bit confusing given the fact, that a test-repository.xml exists as well. I would
> suggest to rename the REPOSITORY_XML constant in RepositoryConfigTest.
> 4) http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/test/repository/repository.xml
> current comment: <!-- Example Repository Configuration File -->
> Usage: i assume, that is the one referenced in test/resources/repositoryStubImpl.properties
> 5) http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/test/resources/org/apache/jackrabbit/core/config/repository.xml
> current comment: <!-- Example Repository Configuration File -->
> Usage: ??
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1306) Reduce number of different
repository.xml present with jackrabbit-core
Posted by "Esteban Franqueiro (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12564019#action_12564019 ]
Esteban Franqueiro commented on JCR-1306:
-----------------------------------------
I agree with Jukka in that we should get rid of all config files that don't have a sound reason to stay where they are. Regarding to Stefan's comment, I think that there could be a new directory in svn called examples or something like that, where we can put different configuration examples.
> Reduce number of different repository.xml present with jackrabbit-core
> ----------------------------------------------------------------------
>
> Key: JCR-1306
> URL: https://issues.apache.org/jira/browse/JCR-1306
> Project: Jackrabbit
> Issue Type: Improvement
> Components: config
> Reporter: angela
> Priority: Minor
>
> while taking a look at the repository configuration and the related test-cases, i saw that there are quite some repository.xml files around... which i think is a bit confusion and probably hard to maintain once we make
> changes to the config.
> i would to suggest to consolidate that and - if possible - get rid of some of them.
> if we can't i would suggest to put some comment in every of the different configuration files indicating
> what they are used for.
> from what i've seen so far (still missing complete overview)
> 1) http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/main/config/repository.xml
> Current comment: <!-- Example Repository Configuration File -->
> Usage: ??
> 2) http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/main/resources/org/apache/jackrabbit/core/test-repository.xml
> current comment: -
> Used as repository configuration in org.apache.jackrabbit.core.TestRepository.java
>
> 3) http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/main/resources/org/apache/jackrabbit/core/repository.xml
>
> current comment: <!-- Example Repository Configuration File -->
> Used by org.apache.jackrabbit.core.config.RepositoryConfigTest.java in order to create another repository.xml
> under target/test-repository.xml. a bit confusing given the fact, that a test-repository.xml exists as well. I would
> suggest to rename the REPOSITORY_XML constant in RepositoryConfigTest.
> 4) http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/test/repository/repository.xml
> current comment: <!-- Example Repository Configuration File -->
> Usage: i assume, that is the one referenced in test/resources/repositoryStubImpl.properties
> 5) http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/test/resources/org/apache/jackrabbit/core/config/repository.xml
> current comment: <!-- Example Repository Configuration File -->
> Usage: ??
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1306) Reduce number of different
repository.xml present with jackrabbit-core
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12563920#action_12563920 ]
Jukka Zitting commented on JCR-1306:
------------------------------------
BTW, I consider the file number 3 above to be the canonical repository configuration file. It's used by TransientRepository when no other configuration is given, and I recently modified the Jackrabbit webapp to also use that file as the default.
> Reduce number of different repository.xml present with jackrabbit-core
> ----------------------------------------------------------------------
>
> Key: JCR-1306
> URL: https://issues.apache.org/jira/browse/JCR-1306
> Project: Jackrabbit
> Issue Type: Improvement
> Components: config
> Reporter: angela
> Priority: Minor
>
> while taking a look at the repository configuration and the related test-cases, i saw that there are quite some repository.xml files around... which i think is a bit confusion and probably hard to maintain once we make
> changes to the config.
> i would to suggest to consolidate that and - if possible - get rid of some of them.
> if we can't i would suggest to put some comment in every of the different configuration files indicating
> what they are used for.
> from what i've seen so far (still missing complete overview)
> 1) http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/main/config/repository.xml
> Current comment: <!-- Example Repository Configuration File -->
> Usage: ??
> 2) http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/main/resources/org/apache/jackrabbit/core/test-repository.xml
> current comment: -
> Used as repository configuration in org.apache.jackrabbit.core.TestRepository.java
>
> 3) http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/main/resources/org/apache/jackrabbit/core/repository.xml
>
> current comment: <!-- Example Repository Configuration File -->
> Used by org.apache.jackrabbit.core.config.RepositoryConfigTest.java in order to create another repository.xml
> under target/test-repository.xml. a bit confusing given the fact, that a test-repository.xml exists as well. I would
> suggest to rename the REPOSITORY_XML constant in RepositoryConfigTest.
> 4) http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/test/repository/repository.xml
> current comment: <!-- Example Repository Configuration File -->
> Usage: i assume, that is the one referenced in test/resources/repositoryStubImpl.properties
> 5) http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/test/resources/org/apache/jackrabbit/core/config/repository.xml
> current comment: <!-- Example Repository Configuration File -->
> Usage: ??
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Issue Comment Edited: (JCR-1306) Reduce number of different
repository.xml present with jackrabbit-core
Posted by "angela (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12578381#action_12578381 ]
anchela edited comment on JCR-1306 at 3/13/08 9:40 AM:
------------------------------------------------------
> I agree with Jukka in that we should get rid of all config files that don't have a sound reason to stay
> where they are.
so do i.
> Regarding to Stefan's comment, I think that there could be a new directory in svn called examples
> or something like that, where we can put different configuration examples.
i'm less convinced about this one... in other words: i wouldn't want (wont) to be the one, that runs after
config changes and makes sure those examples are always up to date.
i tried to reduce to above list of repository.xml and was able to get rid of the following with
moderate to no effort:
1) -> removed without consequences to build process
2) -> removed & modified line 45 in TestRepository.java
5) -> removed without consequences to build process
up to now nobody spoke up for 2) and 5).
unless somebody objects, i will remove those.
regarding 1): i would prefer to remove it, since its not used while building the source. is anybody volunteering to make sure, that is is up to date?
was (Author: anchela):
> I agree with Jukka in that we should get rid of all config files that don't have a sound reason to stay
> where they are.
so do i.
> Regarding to Stefan's comment, I think that there could be a new directory in svn called examples
> or something like that, where we can put different configuration examples.
i'm less convinced about this one... in other words: i wouldn't want (wont) to be the one, that runs after
config changes and makes sure those examples are always up to date.
i tried to reduce to above list of repository.xml and was able to get rid of the following with
moderate to no effort:
1) -> removed without consequences to build process
2) -> modify line 45 in TestRepository.java
5) -> removed without consequences to build process
up to now nobody spoke up for 2) and 5).
unless somebody objects, i will remove those.
regarding 1): i would prefer to remove it, since its not used while building the source. is anybody volunteering to make sure, that is is up to date?
> Reduce number of different repository.xml present with jackrabbit-core
> ----------------------------------------------------------------------
>
> Key: JCR-1306
> URL: https://issues.apache.org/jira/browse/JCR-1306
> Project: Jackrabbit
> Issue Type: Improvement
> Components: config
> Reporter: angela
> Priority: Minor
>
> while taking a look at the repository configuration and the related test-cases, i saw that there are quite some repository.xml files around... which i think is a bit confusion and probably hard to maintain once we make
> changes to the config.
> i would to suggest to consolidate that and - if possible - get rid of some of them.
> if we can't i would suggest to put some comment in every of the different configuration files indicating
> what they are used for.
> from what i've seen so far (still missing complete overview)
> 1) http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/main/config/repository.xml
> Current comment: <!-- Example Repository Configuration File -->
> Usage: ??
> 2) http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/main/resources/org/apache/jackrabbit/core/test-repository.xml
> current comment: -
> Used as repository configuration in org.apache.jackrabbit.core.TestRepository.java
>
> 3) http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/main/resources/org/apache/jackrabbit/core/repository.xml
>
> current comment: <!-- Example Repository Configuration File -->
> Used by org.apache.jackrabbit.core.config.RepositoryConfigTest.java in order to create another repository.xml
> under target/test-repository.xml. a bit confusing given the fact, that a test-repository.xml exists as well. I would
> suggest to rename the REPOSITORY_XML constant in RepositoryConfigTest.
> 4) http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/test/repository/repository.xml
> current comment: <!-- Example Repository Configuration File -->
> Usage: i assume, that is the one referenced in test/resources/repositoryStubImpl.properties
> 5) http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/test/resources/org/apache/jackrabbit/core/config/repository.xml
> current comment: <!-- Example Repository Configuration File -->
> Usage: ??
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1306) Reduce number of different
repository.xml present with jackrabbit-core
Posted by "angela (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12563877#action_12563877 ]
angela commented on JCR-1306:
-----------------------------
does anybody feel responsible for those repository.xml files that i marked with "Usage: ??".
can we remove those?
please comment.
angela
> Reduce number of different repository.xml present with jackrabbit-core
> ----------------------------------------------------------------------
>
> Key: JCR-1306
> URL: https://issues.apache.org/jira/browse/JCR-1306
> Project: Jackrabbit
> Issue Type: Improvement
> Components: config
> Reporter: angela
> Priority: Minor
>
> while taking a look at the repository configuration and the related test-cases, i saw that there are quite some repository.xml files around... which i think is a bit confusion and probably hard to maintain once we make
> changes to the config.
> i would to suggest to consolidate that and - if possible - get rid of some of them.
> if we can't i would suggest to put some comment in every of the different configuration files indicating
> what they are used for.
> from what i've seen so far (still missing complete overview)
> 1) http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/main/config/repository.xml
> Current comment: <!-- Example Repository Configuration File -->
> Usage: ??
> 2) http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/main/resources/org/apache/jackrabbit/core/test-repository.xml
> current comment: -
> Used as repository configuration in org.apache.jackrabbit.core.TestRepository.java
>
> 3) http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/main/resources/org/apache/jackrabbit/core/repository.xml
>
> current comment: <!-- Example Repository Configuration File -->
> Used by org.apache.jackrabbit.core.config.RepositoryConfigTest.java in order to create another repository.xml
> under target/test-repository.xml. a bit confusing given the fact, that a test-repository.xml exists as well. I would
> suggest to rename the REPOSITORY_XML constant in RepositoryConfigTest.
> 4) http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/test/repository/repository.xml
> current comment: <!-- Example Repository Configuration File -->
> Usage: i assume, that is the one referenced in test/resources/repositoryStubImpl.properties
> 5) http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/test/resources/org/apache/jackrabbit/core/config/repository.xml
> current comment: <!-- Example Repository Configuration File -->
> Usage: ??
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1306) Reduce number of different
repository.xml present with jackrabbit-core
Posted by "angela (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12579854#action_12579854 ]
angela commented on JCR-1306:
-----------------------------
revision 638367: removed 2) and 5)
stefan, would you still object to removing 1) as well? please let me know.
> Reduce number of different repository.xml present with jackrabbit-core
> ----------------------------------------------------------------------
>
> Key: JCR-1306
> URL: https://issues.apache.org/jira/browse/JCR-1306
> Project: Jackrabbit
> Issue Type: Improvement
> Components: config
> Reporter: angela
> Priority: Minor
>
> while taking a look at the repository configuration and the related test-cases, i saw that there are quite some repository.xml files around... which i think is a bit confusion and probably hard to maintain once we make
> changes to the config.
> i would to suggest to consolidate that and - if possible - get rid of some of them.
> if we can't i would suggest to put some comment in every of the different configuration files indicating
> what they are used for.
> from what i've seen so far (still missing complete overview)
> 1) http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/main/config/repository.xml
> Current comment: <!-- Example Repository Configuration File -->
> Usage: ??
> 2) http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/main/resources/org/apache/jackrabbit/core/test-repository.xml
> current comment: -
> Used as repository configuration in org.apache.jackrabbit.core.TestRepository.java
>
> 3) http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/main/resources/org/apache/jackrabbit/core/repository.xml
>
> current comment: <!-- Example Repository Configuration File -->
> Used by org.apache.jackrabbit.core.config.RepositoryConfigTest.java in order to create another repository.xml
> under target/test-repository.xml. a bit confusing given the fact, that a test-repository.xml exists as well. I would
> suggest to rename the REPOSITORY_XML constant in RepositoryConfigTest.
> 4) http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/test/repository/repository.xml
> current comment: <!-- Example Repository Configuration File -->
> Usage: i assume, that is the one referenced in test/resources/repositoryStubImpl.properties
> 5) http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/test/resources/org/apache/jackrabbit/core/config/repository.xml
> current comment: <!-- Example Repository Configuration File -->
> Usage: ??
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1306) Reduce number of different
repository.xml present with jackrabbit-core
Posted by "Thomas Mueller (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12578465#action_12578465 ]
Thomas Mueller commented on JCR-1306:
-------------------------------------
+1 remove
About example applications: It would be great to have really simple standalone sample apps for the most important features. I find the following easy to use and manage: The sample apps in the test source tree (maybe better add an 'examples' tree) that write to System.out. Then for each of those sample apps add a test that redirects System.out to a ByteArrayOutputStream, calls the main method, checks if the output is correct. Like that the sample apps don't get out of sync. I will open a new issue about that.
> Reduce number of different repository.xml present with jackrabbit-core
> ----------------------------------------------------------------------
>
> Key: JCR-1306
> URL: https://issues.apache.org/jira/browse/JCR-1306
> Project: Jackrabbit
> Issue Type: Improvement
> Components: config
> Reporter: angela
> Priority: Minor
>
> while taking a look at the repository configuration and the related test-cases, i saw that there are quite some repository.xml files around... which i think is a bit confusion and probably hard to maintain once we make
> changes to the config.
> i would to suggest to consolidate that and - if possible - get rid of some of them.
> if we can't i would suggest to put some comment in every of the different configuration files indicating
> what they are used for.
> from what i've seen so far (still missing complete overview)
> 1) http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/main/config/repository.xml
> Current comment: <!-- Example Repository Configuration File -->
> Usage: ??
> 2) http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/main/resources/org/apache/jackrabbit/core/test-repository.xml
> current comment: -
> Used as repository configuration in org.apache.jackrabbit.core.TestRepository.java
>
> 3) http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/main/resources/org/apache/jackrabbit/core/repository.xml
>
> current comment: <!-- Example Repository Configuration File -->
> Used by org.apache.jackrabbit.core.config.RepositoryConfigTest.java in order to create another repository.xml
> under target/test-repository.xml. a bit confusing given the fact, that a test-repository.xml exists as well. I would
> suggest to rename the REPOSITORY_XML constant in RepositoryConfigTest.
> 4) http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/test/repository/repository.xml
> current comment: <!-- Example Repository Configuration File -->
> Usage: i assume, that is the one referenced in test/resources/repositoryStubImpl.properties
> 5) http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/test/resources/org/apache/jackrabbit/core/config/repository.xml
> current comment: <!-- Example Repository Configuration File -->
> Usage: ??
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Resolved: (JCR-1306) Reduce number of different
repository.xml present with jackrabbit-core
Posted by "angela (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1306?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
angela resolved JCR-1306.
-------------------------
Resolution: Fixed
Assignee: angela
removed 1) too.
> Reduce number of different repository.xml present with jackrabbit-core
> ----------------------------------------------------------------------
>
> Key: JCR-1306
> URL: https://issues.apache.org/jira/browse/JCR-1306
> Project: Jackrabbit
> Issue Type: Improvement
> Components: config
> Reporter: angela
> Assignee: angela
> Priority: Minor
>
> while taking a look at the repository configuration and the related test-cases, i saw that there are quite some repository.xml files around... which i think is a bit confusion and probably hard to maintain once we make
> changes to the config.
> i would to suggest to consolidate that and - if possible - get rid of some of them.
> if we can't i would suggest to put some comment in every of the different configuration files indicating
> what they are used for.
> from what i've seen so far (still missing complete overview)
> 1) http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/main/config/repository.xml
> Current comment: <!-- Example Repository Configuration File -->
> Usage: ??
> 2) http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/main/resources/org/apache/jackrabbit/core/test-repository.xml
> current comment: -
> Used as repository configuration in org.apache.jackrabbit.core.TestRepository.java
>
> 3) http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/main/resources/org/apache/jackrabbit/core/repository.xml
>
> current comment: <!-- Example Repository Configuration File -->
> Used by org.apache.jackrabbit.core.config.RepositoryConfigTest.java in order to create another repository.xml
> under target/test-repository.xml. a bit confusing given the fact, that a test-repository.xml exists as well. I would
> suggest to rename the REPOSITORY_XML constant in RepositoryConfigTest.
> 4) http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/test/repository/repository.xml
> current comment: <!-- Example Repository Configuration File -->
> Usage: i assume, that is the one referenced in test/resources/repositoryStubImpl.properties
> 5) http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/test/resources/org/apache/jackrabbit/core/config/repository.xml
> current comment: <!-- Example Repository Configuration File -->
> Usage: ??
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1306) Reduce number of different
repository.xml present with jackrabbit-core
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12563919#action_12563919 ]
Jukka Zitting commented on JCR-1306:
------------------------------------
Unless there's overwhelming reason not to do so, I'd rather get rid of all but one repository.xml file.
As for having an example configuration file, IMHO it's better to put up a configuration page on the web site and, if needed, point directly to the "official" one in o.a.j.core.
> Reduce number of different repository.xml present with jackrabbit-core
> ----------------------------------------------------------------------
>
> Key: JCR-1306
> URL: https://issues.apache.org/jira/browse/JCR-1306
> Project: Jackrabbit
> Issue Type: Improvement
> Components: config
> Reporter: angela
> Priority: Minor
>
> while taking a look at the repository configuration and the related test-cases, i saw that there are quite some repository.xml files around... which i think is a bit confusion and probably hard to maintain once we make
> changes to the config.
> i would to suggest to consolidate that and - if possible - get rid of some of them.
> if we can't i would suggest to put some comment in every of the different configuration files indicating
> what they are used for.
> from what i've seen so far (still missing complete overview)
> 1) http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/main/config/repository.xml
> Current comment: <!-- Example Repository Configuration File -->
> Usage: ??
> 2) http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/main/resources/org/apache/jackrabbit/core/test-repository.xml
> current comment: -
> Used as repository configuration in org.apache.jackrabbit.core.TestRepository.java
>
> 3) http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/main/resources/org/apache/jackrabbit/core/repository.xml
>
> current comment: <!-- Example Repository Configuration File -->
> Used by org.apache.jackrabbit.core.config.RepositoryConfigTest.java in order to create another repository.xml
> under target/test-repository.xml. a bit confusing given the fact, that a test-repository.xml exists as well. I would
> suggest to rename the REPOSITORY_XML constant in RepositoryConfigTest.
> 4) http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/test/repository/repository.xml
> current comment: <!-- Example Repository Configuration File -->
> Usage: i assume, that is the one referenced in test/resources/repositoryStubImpl.properties
> 5) http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/test/resources/org/apache/jackrabbit/core/config/repository.xml
> current comment: <!-- Example Repository Configuration File -->
> Usage: ??
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1306) Reduce number of different
repository.xml present with jackrabbit-core
Posted by "Stefan Guggisberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12580281#action_12580281 ]
Stefan Guggisberg commented on JCR-1306:
----------------------------------------
> stefan, would you still object to removing 1) as well? please let me know.
no, that's fine with me. thanks.
> Reduce number of different repository.xml present with jackrabbit-core
> ----------------------------------------------------------------------
>
> Key: JCR-1306
> URL: https://issues.apache.org/jira/browse/JCR-1306
> Project: Jackrabbit
> Issue Type: Improvement
> Components: config
> Reporter: angela
> Priority: Minor
>
> while taking a look at the repository configuration and the related test-cases, i saw that there are quite some repository.xml files around... which i think is a bit confusion and probably hard to maintain once we make
> changes to the config.
> i would to suggest to consolidate that and - if possible - get rid of some of them.
> if we can't i would suggest to put some comment in every of the different configuration files indicating
> what they are used for.
> from what i've seen so far (still missing complete overview)
> 1) http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/main/config/repository.xml
> Current comment: <!-- Example Repository Configuration File -->
> Usage: ??
> 2) http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/main/resources/org/apache/jackrabbit/core/test-repository.xml
> current comment: -
> Used as repository configuration in org.apache.jackrabbit.core.TestRepository.java
>
> 3) http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/main/resources/org/apache/jackrabbit/core/repository.xml
>
> current comment: <!-- Example Repository Configuration File -->
> Used by org.apache.jackrabbit.core.config.RepositoryConfigTest.java in order to create another repository.xml
> under target/test-repository.xml. a bit confusing given the fact, that a test-repository.xml exists as well. I would
> suggest to rename the REPOSITORY_XML constant in RepositoryConfigTest.
> 4) http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/test/repository/repository.xml
> current comment: <!-- Example Repository Configuration File -->
> Usage: i assume, that is the one referenced in test/resources/repositoryStubImpl.properties
> 5) http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/test/resources/org/apache/jackrabbit/core/config/repository.xml
> current comment: <!-- Example Repository Configuration File -->
> Usage: ??
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1306) Reduce number of different
repository.xml present with jackrabbit-core
Posted by "Stefan Guggisberg (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12563917#action_12563917 ]
Stefan Guggisberg commented on JCR-1306:
----------------------------------------
> 1) http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/main/config/repository.xml
i think it's a good idea having an example repository.xml in svn.
src/main/config is IMO a good place since most people would probably look for it there first.
> Reduce number of different repository.xml present with jackrabbit-core
> ----------------------------------------------------------------------
>
> Key: JCR-1306
> URL: https://issues.apache.org/jira/browse/JCR-1306
> Project: Jackrabbit
> Issue Type: Improvement
> Components: config
> Reporter: angela
> Priority: Minor
>
> while taking a look at the repository configuration and the related test-cases, i saw that there are quite some repository.xml files around... which i think is a bit confusion and probably hard to maintain once we make
> changes to the config.
> i would to suggest to consolidate that and - if possible - get rid of some of them.
> if we can't i would suggest to put some comment in every of the different configuration files indicating
> what they are used for.
> from what i've seen so far (still missing complete overview)
> 1) http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/main/config/repository.xml
> Current comment: <!-- Example Repository Configuration File -->
> Usage: ??
> 2) http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/main/resources/org/apache/jackrabbit/core/test-repository.xml
> current comment: -
> Used as repository configuration in org.apache.jackrabbit.core.TestRepository.java
>
> 3) http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/main/resources/org/apache/jackrabbit/core/repository.xml
>
> current comment: <!-- Example Repository Configuration File -->
> Used by org.apache.jackrabbit.core.config.RepositoryConfigTest.java in order to create another repository.xml
> under target/test-repository.xml. a bit confusing given the fact, that a test-repository.xml exists as well. I would
> suggest to rename the REPOSITORY_XML constant in RepositoryConfigTest.
> 4) http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/test/repository/repository.xml
> current comment: <!-- Example Repository Configuration File -->
> Usage: i assume, that is the one referenced in test/resources/repositoryStubImpl.properties
> 5) http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/test/resources/org/apache/jackrabbit/core/config/repository.xml
> current comment: <!-- Example Repository Configuration File -->
> Usage: ??
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1306) Reduce number of different
repository.xml present with jackrabbit-core
Posted by "Jukka Zitting (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12578384#action_12578384 ]
Jukka Zitting commented on JCR-1306:
------------------------------------
+1 to removing 1, 2, and 5
> Reduce number of different repository.xml present with jackrabbit-core
> ----------------------------------------------------------------------
>
> Key: JCR-1306
> URL: https://issues.apache.org/jira/browse/JCR-1306
> Project: Jackrabbit
> Issue Type: Improvement
> Components: config
> Reporter: angela
> Priority: Minor
>
> while taking a look at the repository configuration and the related test-cases, i saw that there are quite some repository.xml files around... which i think is a bit confusion and probably hard to maintain once we make
> changes to the config.
> i would to suggest to consolidate that and - if possible - get rid of some of them.
> if we can't i would suggest to put some comment in every of the different configuration files indicating
> what they are used for.
> from what i've seen so far (still missing complete overview)
> 1) http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/main/config/repository.xml
> Current comment: <!-- Example Repository Configuration File -->
> Usage: ??
> 2) http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/main/resources/org/apache/jackrabbit/core/test-repository.xml
> current comment: -
> Used as repository configuration in org.apache.jackrabbit.core.TestRepository.java
>
> 3) http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/main/resources/org/apache/jackrabbit/core/repository.xml
>
> current comment: <!-- Example Repository Configuration File -->
> Used by org.apache.jackrabbit.core.config.RepositoryConfigTest.java in order to create another repository.xml
> under target/test-repository.xml. a bit confusing given the fact, that a test-repository.xml exists as well. I would
> suggest to rename the REPOSITORY_XML constant in RepositoryConfigTest.
> 4) http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/test/repository/repository.xml
> current comment: <!-- Example Repository Configuration File -->
> Usage: i assume, that is the one referenced in test/resources/repositoryStubImpl.properties
> 5) http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/test/resources/org/apache/jackrabbit/core/config/repository.xml
> current comment: <!-- Example Repository Configuration File -->
> Usage: ??
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (JCR-1306) Reduce number of different
repository.xml present with jackrabbit-core
Posted by "angela (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/JCR-1306?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12578381#action_12578381 ]
angela commented on JCR-1306:
-----------------------------
> I agree with Jukka in that we should get rid of all config files that don't have a sound reason to stay
> where they are.
so do i.
> Regarding to Stefan's comment, I think that there could be a new directory in svn called examples
> or something like that, where we can put different configuration examples.
i'm less convinced about this one... in other words: i wouldn't want (wont) to be the one, that runs after
config changes and makes sure those examples are always up to date.
i tried to reduce to above list of repository.xml and was able to get rid of the following with
moderate to no effort:
1) -> removed without consequences to build process
2) -> modify line 45 in TestRepository.java
5) -> removed without consequences to build process
up to now nobody spoke up for 2) and 5).
unless somebody objects, i will remove those.
regarding 1): i would prefer to remove it, since its not used while building the source. is anybody volunteering to make sure, that is is up to date?
> Reduce number of different repository.xml present with jackrabbit-core
> ----------------------------------------------------------------------
>
> Key: JCR-1306
> URL: https://issues.apache.org/jira/browse/JCR-1306
> Project: Jackrabbit
> Issue Type: Improvement
> Components: config
> Reporter: angela
> Priority: Minor
>
> while taking a look at the repository configuration and the related test-cases, i saw that there are quite some repository.xml files around... which i think is a bit confusion and probably hard to maintain once we make
> changes to the config.
> i would to suggest to consolidate that and - if possible - get rid of some of them.
> if we can't i would suggest to put some comment in every of the different configuration files indicating
> what they are used for.
> from what i've seen so far (still missing complete overview)
> 1) http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/main/config/repository.xml
> Current comment: <!-- Example Repository Configuration File -->
> Usage: ??
> 2) http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/main/resources/org/apache/jackrabbit/core/test-repository.xml
> current comment: -
> Used as repository configuration in org.apache.jackrabbit.core.TestRepository.java
>
> 3) http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/main/resources/org/apache/jackrabbit/core/repository.xml
>
> current comment: <!-- Example Repository Configuration File -->
> Used by org.apache.jackrabbit.core.config.RepositoryConfigTest.java in order to create another repository.xml
> under target/test-repository.xml. a bit confusing given the fact, that a test-repository.xml exists as well. I would
> suggest to rename the REPOSITORY_XML constant in RepositoryConfigTest.
> 4) http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/test/repository/repository.xml
> current comment: <!-- Example Repository Configuration File -->
> Usage: i assume, that is the one referenced in test/resources/repositoryStubImpl.properties
> 5) http://svn.apache.org/repos/asf/jackrabbit/trunk/jackrabbit-core/src/test/resources/org/apache/jackrabbit/core/config/repository.xml
> current comment: <!-- Example Repository Configuration File -->
> Usage: ??
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.