You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/01/25 02:31:34 UTC
[GitHub] [incubator-doris] adonis0147 opened a new pull request #7874: [Improvement] (fe-unit-test) Pass conf map to create Doris cluster.
adonis0147 opened a new pull request #7874:
URL: https://github.com/apache/incubator-doris/pull/7874
# Proposed changes
Issue Number: close #7873
## Problem Summary:
Passing conf map to create Doris cluster which can change some fe configuration while running fe unit tests.
## Checklist(Required)
1. Does it affect the original behavior: No.
2. Has unit tests been added: Yes.
3. Has document been added or modified: No Need.
4. Does it need to update dependencies: No.
5. Are there any changes that cannot be rolled back: No.
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] adonis0147 edited a comment on pull request #7874: [Improvement] (fe-unit-test) Pass conf map to create Doris cluster.
Posted by GitBox <gi...@apache.org>.
adonis0147 edited a comment on pull request #7874:
URL: https://github.com/apache/incubator-doris/pull/7874#issuecomment-1020760870
This alternative initializes the configuration before the cluster starts by serializing the configuration to `fe.conf`.
It is fine to ignore this pull request because there are some alternatives can achieve the same effect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on pull request #7874: [Improvement] (fe-unit-test) Pass conf map to create Doris cluster.
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 commented on pull request #7874:
URL: https://github.com/apache/incubator-doris/pull/7874#issuecomment-1020758021
At present, Doris's single test framework will set the configuration directly through Config.xxx=xxx, such as QueryPlanTest.java:1806
What's the difference between the two settings?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] adonis0147 commented on pull request #7874: [Improvement] (fe-unit-test) Pass conf map to create Doris cluster.
Posted by GitBox <gi...@apache.org>.
adonis0147 commented on pull request #7874:
URL: https://github.com/apache/incubator-doris/pull/7874#issuecomment-1020760870
This alternative initializes the configuration before the cluster starts by serializing the configuration to `fe.conf`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] adonis0147 edited a comment on pull request #7874: [Improvement] (fe-unit-test) Pass conf map to create Doris cluster.
Posted by GitBox <gi...@apache.org>.
adonis0147 edited a comment on pull request #7874:
URL: https://github.com/apache/incubator-doris/pull/7874#issuecomment-1020760870
This alternative initializes the configuration before the cluster starts by serializing the configuration to `fe.conf`.
It is fine to ignore this pull request because there are some alternatives which can achieve the same effect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] adonis0147 commented on pull request #7874: [Improvement] (fe-unit-test) Pass conf map to create Doris cluster.
Posted by GitBox <gi...@apache.org>.
adonis0147 commented on pull request #7874:
URL: https://github.com/apache/incubator-doris/pull/7874#issuecomment-1020760870
This alternative initializes the configuration before the cluster starts by serializing the configuration to `fe.conf`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] adonis0147 edited a comment on pull request #7874: [Improvement] (fe-unit-test) Pass conf map to create Doris cluster.
Posted by GitBox <gi...@apache.org>.
adonis0147 edited a comment on pull request #7874:
URL: https://github.com/apache/incubator-doris/pull/7874#issuecomment-1020760870
This alternative initializes the configuration before the cluster starts by serializing the configuration to `fe.conf`.
It is fine to ignore this pull request if there are some alternatives which can achieve the same effect.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] adonis0147 edited a comment on pull request #7874: [Improvement] (fe-unit-test) Pass conf map to create Doris cluster.
Posted by GitBox <gi...@apache.org>.
adonis0147 edited a comment on pull request #7874:
URL: https://github.com/apache/incubator-doris/pull/7874#issuecomment-1020760870
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] EmmyMiao87 commented on pull request #7874: [Improvement] (fe-unit-test) Pass conf map to create Doris cluster.
Posted by GitBox <gi...@apache.org>.
EmmyMiao87 commented on pull request #7874:
URL: https://github.com/apache/incubator-doris/pull/7874#issuecomment-1020758021
At present, Doris's single test framework will set the configuration directly through Config.xxx=xxx, such as QueryPlanTest.java:1806
What's the difference between the two settings?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [incubator-doris] adonis0147 closed pull request #7874: [Improvement] (fe-unit-test) Pass conf map to create Doris cluster.
Posted by GitBox <gi...@apache.org>.
adonis0147 closed pull request #7874:
URL: https://github.com/apache/incubator-doris/pull/7874
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org