You are viewing a plain text version of this content. The canonical link for it is here.
Posted to java-dev@axis.apache.org by "Rich Scheuerle (JIRA)" <ji...@apache.org> on 2007/04/10 19:16:32 UTC

[jira] Created: (AXIS2-2495) JAX-WS Performance (SpineImpl should close XMLStreamReader)

JAX-WS Performance (SpineImpl should close XMLStreamReader)
-----------------------------------------------------------

                 Key: AXIS2-2495
                 URL: https://issues.apache.org/jira/browse/AXIS2-2495
             Project: Axis 2.0 (Axis2)
          Issue Type: Bug
            Reporter: Rich Scheuerle
         Assigned To: Rich Scheuerle


The JAX-WS XMLSpineImpl code uses an OMSourcedElement to store the data (normally a JAXB object) in the OM
tree.

During performance analysis we realized that even though the code is pulling all of the body events to create the JAXBElement, 
the remainder of the events in the message are not pulled.  This means that the XMLStreamReader (and ultimately the parser) is never closed.

Failure to close the parser can result in severe performance penalties, which are dependent on the parser implemenation.  For example, the parser may not adequately free its resources.

Prior to these changes, I tagged the code in XMLSpineImpl with a TODO statement to review the code.

In a few minutes I will commit the real fix.  This should not cause any logical differences.

Thanks,
Rich

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org


[jira] Resolved: (AXIS2-2495) JAX-WS Performance (SpineImpl should close XMLStreamReader)

Posted by "Rich Scheuerle (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/AXIS2-2495?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rich Scheuerle resolved AXIS2-2495.
-----------------------------------

    Resolution: Fixed

Revision 527205

> JAX-WS Performance (SpineImpl should close XMLStreamReader)
> -----------------------------------------------------------
>
>                 Key: AXIS2-2495
>                 URL: https://issues.apache.org/jira/browse/AXIS2-2495
>             Project: Axis 2.0 (Axis2)
>          Issue Type: Bug
>            Reporter: Rich Scheuerle
>         Assigned To: Rich Scheuerle
>
> The JAX-WS XMLSpineImpl code uses an OMSourcedElement to store the data (normally a JAXB object) in the OM
> tree.
> During performance analysis we realized that even though the code is pulling all of the body events to create the JAXBElement, 
> the remainder of the events in the message are not pulled.  This means that the XMLStreamReader (and ultimately the parser) is never closed.
> Failure to close the parser can result in severe performance penalties, which are dependent on the parser implemenation.  For example, the parser may not adequately free its resources.
> Prior to these changes, I tagged the code in XMLSpineImpl with a TODO statement to review the code.
> In a few minutes I will commit the real fix.  This should not cause any logical differences.
> Thanks,
> Rich

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


---------------------------------------------------------------------
To unsubscribe, e-mail: axis-dev-unsubscribe@ws.apache.org
For additional commands, e-mail: axis-dev-help@ws.apache.org