You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/09/16 00:39:15 UTC
[GitHub] [hudi] rahil-c opened a new pull request, #6688: Fix AWSDmsAvroPayload#combineAndGetUpdateValue when using MOR snapshot query after delete operations
rahil-c opened a new pull request, #6688:
URL: https://github.com/apache/hudi/pull/6688
### Change Logs
_Describe context and summary for this change. Highlight if any code was copied._
### Impact
_Describe any public API or user-facing feature change or any performance impact._
**Risk level: none | low | medium | high**
_Choose one. If medium or high, explain what verification was done to mitigate the risks._
### Contributor's checklist
- [ ] Read through [contributor's guide](https://hudi.apache.org/contribute/how-to-contribute)
- [ ] Change Logs and Impact were stated clearly
- [ ] Adequate tests were added if applicable
- [ ] CI passed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6688: Fix AWSDmsAvroPayload#combineAndGetUpdateValue when using MOR snapshot query after delete operations
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6688:
URL: https://github.com/apache/hudi/pull/6688#issuecomment-1248806264
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fff1405467fb5f6a7fdb6d3d043714e268f1c875",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "fff1405467fb5f6a7fdb6d3d043714e268f1c875",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fff1405467fb5f6a7fdb6d3d043714e268f1c875 UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6688: Fix AWSDmsAvroPayload#combineAndGetUpdateValue when using MOR snapshot query after delete operations
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6688:
URL: https://github.com/apache/hudi/pull/6688#issuecomment-1248808723
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fff1405467fb5f6a7fdb6d3d043714e268f1c875",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11398",
"triggerID" : "fff1405467fb5f6a7fdb6d3d043714e268f1c875",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fff1405467fb5f6a7fdb6d3d043714e268f1c875 Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11398)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua commented on pull request #6688: Fix AWSDmsAvroPayload#combineAndGetUpdateValue when using MOR snapshot query after delete operations
Posted by GitBox <gi...@apache.org>.
yihua commented on PR #6688:
URL: https://github.com/apache/hudi/pull/6688#issuecomment-1249550520
@rahil-c I'll wait for you to add a test before merging this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6688: Fix AWSDmsAvroPayload#combineAndGetUpdateValue when using MOR snapshot query after delete operations
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6688:
URL: https://github.com/apache/hudi/pull/6688#issuecomment-1248917319
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fff1405467fb5f6a7fdb6d3d043714e268f1c875",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11398",
"triggerID" : "fff1405467fb5f6a7fdb6d3d043714e268f1c875",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fff1405467fb5f6a7fdb6d3d043714e268f1c875 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11398)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] rahil-c commented on pull request #6688: Fix AWSDmsAvroPayload#combineAndGetUpdateValue when using MOR snapshot query after delete operations
Posted by GitBox <gi...@apache.org>.
rahil-c commented on PR #6688:
URL: https://github.com/apache/hudi/pull/6688#issuecomment-1249916684
@yihua Was able to add test which exposed the constructor issue as well as the same `combineAndGetValue` issue that aws customer saw
```
Caused by: java.util.NoSuchElementException: No value present in Option
at org.apache.hudi.common.util.Option.get(Option.java:88)
at org.apache.hudi.common.model.AWSDmsAvroPayload.<init>(AWSDmsAvroPayload.java:52)
... 35 more
```
```
ava.util.NoSuchElementException: No value present in Option
at org.apache.hudi.common.util.Option.get(Option.java:89)
at org.apache.hudi.common.model.AWSDmsAvroPayload.combineAndGetUpdateValue(AWSDmsAvroPayload.java:90)
at org.apache.hudi.common.model.AWSDmsAvroPayload.combineAndGetUpdateValue(AWSDmsAvroPayload.java:84)
at org.apache.hudi.common.model.TestAWSDmsAvroPayload.testDeleteWithEmptyPayLoad(TestAWSDmsAvroPayload.java:123)
```
with this fix both issues are gone.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] yihua merged pull request #6688: [HUDI-4864] Fix AWSDmsAvroPayload#combineAndGetUpdateValue when using MOR snapshot query after delete operations
Posted by GitBox <gi...@apache.org>.
yihua merged PR #6688:
URL: https://github.com/apache/hudi/pull/6688
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6688: [HUDI-4864] Fix AWSDmsAvroPayload#combineAndGetUpdateValue when using MOR snapshot query after delete operations
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6688:
URL: https://github.com/apache/hudi/pull/6688#issuecomment-1249930871
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fff1405467fb5f6a7fdb6d3d043714e268f1c875",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11398",
"triggerID" : "fff1405467fb5f6a7fdb6d3d043714e268f1c875",
"triggerType" : "PUSH"
}, {
"hash" : "0ef01c16f09f8b46bda5541f03b3e6c1c97210fc",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "0ef01c16f09f8b46bda5541f03b3e6c1c97210fc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fff1405467fb5f6a7fdb6d3d043714e268f1c875 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11398)
* 0ef01c16f09f8b46bda5541f03b3e6c1c97210fc UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #6688: [HUDI-4864] Fix AWSDmsAvroPayload#combineAndGetUpdateValue when using MOR snapshot query after delete operations
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on PR #6688:
URL: https://github.com/apache/hudi/pull/6688#issuecomment-1249932808
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "fff1405467fb5f6a7fdb6d3d043714e268f1c875",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11398",
"triggerID" : "fff1405467fb5f6a7fdb6d3d043714e268f1c875",
"triggerType" : "PUSH"
}, {
"hash" : "0ef01c16f09f8b46bda5541f03b3e6c1c97210fc",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11436",
"triggerID" : "0ef01c16f09f8b46bda5541f03b3e6c1c97210fc",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* fff1405467fb5f6a7fdb6d3d043714e268f1c875 Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11398)
* 0ef01c16f09f8b46bda5541f03b3e6c1c97210fc Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=11436)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org