review requested: [Bug 119118] z command in d attribute in svg sets the 'current point' wrong : [Attachment 81710] Set current point correctly and allow non moveto after z

[bu...@apache.org]

Regina Henschel <rb...@t-online.de> has asked  for review:
Bug 119118: z command in d attribute in svg sets the 'current point' wrong
https://issues.apache.org/ooo/show_bug.cgi?id=119118

Attachment 81710: Set current point correctly and allow non moveto after z
https://issues.apache.org/ooo/attachment.cgi?id=81710&action=edit


------- Additional Comments from Regina Henschel <rb...@t-online.de>
With the current implementation of the property "closed" it is not possible to
match svg:d totally. Reasoning: svg:d allows, that after a z command, other
commands than m,M may follow. Especially it is possible to use lines. In AOO
the end of this lines are connected to the start point because the property
"close" cannot be set to a part of the path. Despite the mentioned fix in LO,
LO 4.2 shows such svg-graphics still wrong.

My idea is, to finish the path after a z command in any case. If a open path
end in svg:d follows after z, it remains open in AOO. This way marker-ends are
drawn correctly, the shape itself looks correct, and no additional line
appears.

The shortcoming is, that the separated subpath generates an additional
marker-mid at the connecting point, and that this marker and the marker-mid of
the close part in this point, have the wrong direction. And I see no way to
detect a true moveto from such pseudo moveto, which will affect solutions for
bug 123410.

I assume that a wrong marker-mid is not so bad as a wrong marker-end or as
additional lines for shape closing. Therefore I suggest to use this patch, till
there will be at some time a change in the implementation of draw:path.