You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2022/02/10 13:43:11 UTC
[GitHub] [hudi] xiarixiaoyao opened a new pull request #4785: [HUDI-3408] fixed the bug that BUCKET_INDEX cannot process special ch…
xiarixiaoyao opened a new pull request #4785:
URL: https://github.com/apache/hudi/pull/4785
…aracters
## *Tips*
- *Thank you very much for contributing to Apache Hudi.*
- *Please review https://hudi.apache.org/contribute/how-to-contribute before opening a pull request.*
## What is the purpose of the pull request
``` withTempDir { tmp =>
Seq("mor").foreach { tableType =>
val tableName = generateTableName
val tablePath = s"${new Path(tmp.getCanonicalPath, tableName).toUri.toString}"
spark.sql(
s"""
|create table $tableName (
| id int, comb int, col0 int, col1 bigint, col2 float, col3 double, col4 decimal(10,4), col5 string, col6 date, col7 timestamp, col8 boolean, col9 binary, par date
|) using hudi
| location '$tablePath'
| options (
| type = '$tableType',
| primaryKey = 'id,col0,col5',
| preCombineField = 'comb',
| hoodie.index.type = 'BUCKET',
| hoodie.bucket.index.num.buckets = '900'
| )
| partitioned by (par)
""".stripMargin)
spark.sql(
s"""
| insert into $tableName values
| (1,1,11,100001,101.01,1001.0001,100001.0001,':::','2021-12-25','2021-12-25 12:01:01',true,'a01','2021-12-25'),
| (2,2,12,100002,102.02,1002.0002,100002.0002,'a000002','2021-12-25','2021-12-25 12:02:02',true,'a02','2021-12-25'),
| (3,3,13,100003,103.03,1003.0003,100003.0003,'a000003','2021-12-25','2021-12-25 12:03:03',false,'a03','2021-12-25'),
| (4,4,14,100004,104.04,1004.0004,100004.0004,'a000004','2021-12-26','2021-12-26 12:04:04',true,'a04','2021-12-26'),
| (5,5,15,100005,105.05,1005.0005,100005.0005,'a000005','2021-12-26','2021-12-26 12:05:05',false,'a05','2021-12-26')
|""".stripMargin)
}
}
}```
Caused by: java.lang.ArrayIndexOutOfBoundsException: 1
at org.apache.hudi.index.bucket.BucketIdentifier.lambda$getBucketId$2(BucketIdentifier.java:46)
at java.util.stream.Collectors.lambda$toMap$58(Collectors.java:1321)
at java.util.stream.ReduceOps$3ReducingSink.accept(ReduceOps.java:169)
at java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:193)
at java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:948)
at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:481)
at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:471)
at java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:708)
at java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234)
at java.util.stream.ReferencePipeline.collect(ReferencePipeline.java:499)
at org.apache.hudi.index.bucket.BucketIdentifier.getBucketId(BucketIdentifier.java:46)
at org.apache.hudi.index.bucket.BucketIdentifier.getBucketId(BucketIdentifier.java:36)
at org.apache.hudi.index.bucket.SparkBucketIndex$1.computeNext(SparkBucketIndex.java:80)
at org.apache.hudi.index.bucket.SparkBucketIndex$1.computeNext(SparkBucketIndex.java:70)
at org.apache.hudi.client.utils.LazyIterableIterator.next(LazyIterableIterator.java:125)
... 25 more
*(for example:)*
- *Modify AnnotationLocation checkstyle rule in checkstyle.xml*
## Verify this pull request
*(Please pick either of the following options)*
This pull request is a trivial rework / code cleanup without any test coverage.
*(or)*
This pull request is already covered by existing tests, such as *(please describe tests)*.
(or)
This change added tests and can be verified as follows:
*(example:)*
- *Added integration tests for end-to-end.*
- *Added HoodieClientWriteTest to verify the change.*
- *Manually verified the change by running a job locally.*
## Committer checklist
- [ ] Has a corresponding JIRA in PR title & commit
- [ ] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xiarixiaoyao commented on a change in pull request #4785: [HUDI-3408] fixed the bug that BUCKET_INDEX cannot process special ch…
Posted by GitBox <gi...@apache.org>.
xiarixiaoyao commented on a change in pull request #4785:
URL: https://github.com/apache/hudi/pull/4785#discussion_r805752004
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/bucket/BucketIdentifier.java
##########
@@ -43,7 +43,7 @@ public static int getBucketId(HoodieKey hoodieKey, String indexKeyFields, int nu
} else {
Map<String, String> recordKeyPairs = Arrays.stream(hoodieKey.getRecordKey().split(","))
.map(p -> p.split(":"))
- .collect(Collectors.toMap(p -> p[0], p -> p[1]));
+ .collect(Collectors.toMap(p -> p[0], p -> p.length == 1 ? "" : p[1]));
hashKeyFields = Arrays.stream(indexKeyFields.split(","))
Review comment:
Our users use a composite primary key （col1， col2， col3）. The value of col3 contains special characters
This problem occurs as long as the column value consists of ':'
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] minihippo edited a comment on pull request #4785: [HUDI-3408] fixed the bug that BUCKET_INDEX cannot process special ch…
Posted by GitBox <gi...@apache.org>.
minihippo edited a comment on pull request #4785:
URL: https://github.com/apache/hudi/pull/4785#issuecomment-1041505103
>
> @minihippo yes will do it, but i still have some problems, [BucketIdentifier.java](https://github.com/apache/hudi/pull/4785/files#diff-cec97cf4da631039da992f4b6d21424c18a39ced051e2c2faf3739b40b9ebec6) will give a hash value for recordKey, Why don't we just use the hash value of recordkey ？
@xiarixiaoyao Hudi is commonly used to store data warehouse summary tables at ByteDance. Summary table is organized with dimensions and indexes. Id and dimension is composite primary key. Bucket key can be one of the dimension which is frequently aggregated by data analytics to accelerated query. In the above scenario, the primary key is a complex type: id and dimension column.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xiarixiaoyao commented on pull request #4785: [HUDI-3408] fixed the bug that BUCKET_INDEX cannot process special ch…
Posted by GitBox <gi...@apache.org>.
xiarixiaoyao commented on pull request #4785:
URL: https://github.com/apache/hudi/pull/4785#issuecomment-1082564919
@danny0405 @minihippo Thank you very much for your review. maybe this is not a very common problem in product env， let me close it。
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xiarixiaoyao commented on pull request #4785: [HUDI-3408] fixed the bug that BUCKET_INDEX cannot process special ch…
Posted by GitBox <gi...@apache.org>.
xiarixiaoyao commented on pull request #4785:
URL: https://github.com/apache/hudi/pull/4785#issuecomment-1034940001
@minihippo could you pls help me to review this code， thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xiarixiaoyao closed pull request #4785: [HUDI-3408] fixed the bug that BUCKET_INDEX cannot process special ch…
Posted by GitBox <gi...@apache.org>.
xiarixiaoyao closed pull request #4785:
URL: https://github.com/apache/hudi/pull/4785
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4785: [HUDI-3408] fixed the bug that BUCKET_INDEX cannot process special ch…
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4785:
URL: https://github.com/apache/hudi/pull/4785#issuecomment-1034943901
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ac1b8e67a20b4b891d8a58c212e462ccd9ae8c5c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5874",
"triggerID" : "ac1b8e67a20b4b891d8a58c212e462ccd9ae8c5c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ac1b8e67a20b4b891d8a58c212e462ccd9ae8c5c Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5874)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4785: [HUDI-3408] fixed the bug that BUCKET_INDEX cannot process special ch…
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4785:
URL: https://github.com/apache/hudi/pull/4785#issuecomment-1035015004
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ac1b8e67a20b4b891d8a58c212e462ccd9ae8c5c",
"status" : "SUCCESS",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5874",
"triggerID" : "ac1b8e67a20b4b891d8a58c212e462ccd9ae8c5c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ac1b8e67a20b4b891d8a58c212e462ccd9ae8c5c Azure: [SUCCESS](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5874)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot removed a comment on pull request #4785: [HUDI-3408] fixed the bug that BUCKET_INDEX cannot process special ch…
Posted by GitBox <gi...@apache.org>.
hudi-bot removed a comment on pull request #4785:
URL: https://github.com/apache/hudi/pull/4785#issuecomment-1034940781
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ac1b8e67a20b4b891d8a58c212e462ccd9ae8c5c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ac1b8e67a20b4b891d8a58c212e462ccd9ae8c5c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ac1b8e67a20b4b891d8a58c212e462ccd9ae8c5c UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xiarixiaoyao commented on pull request #4785: [HUDI-3408] fixed the bug that BUCKET_INDEX cannot process special ch…
Posted by GitBox <gi...@apache.org>.
xiarixiaoyao commented on pull request #4785:
URL: https://github.com/apache/hudi/pull/4785#issuecomment-1038535231
@nsivabalan @minihippo If you have time, cou.ld you pls help to review this pr， thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xiarixiaoyao commented on pull request #4785: [HUDI-3408] fixed the bug that BUCKET_INDEX cannot process special ch…
Posted by GitBox <gi...@apache.org>.
xiarixiaoyao commented on pull request #4785:
URL: https://github.com/apache/hudi/pull/4785#issuecomment-1038535231
@nsivabalan @minihippo If you have time, cou.ld you pls help to review this pr， thanks
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a change in pull request #4785: [HUDI-3408] fixed the bug that BUCKET_INDEX cannot process special ch…
Posted by GitBox <gi...@apache.org>.
danny0405 commented on a change in pull request #4785:
URL: https://github.com/apache/hudi/pull/4785#discussion_r838058918
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/bucket/BucketIdentifier.java
##########
@@ -43,7 +43,7 @@ public static int getBucketId(HoodieKey hoodieKey, String indexKeyFields, int nu
} else {
Map<String, String> recordKeyPairs = Arrays.stream(hoodieKey.getRecordKey().split(","))
.map(p -> p.split(":"))
- .collect(Collectors.toMap(p -> p[0], p -> p[1]));
+ .collect(Collectors.toMap(p -> p[0], p -> p.length == 1 ? "" : p[1]));
hashKeyFields = Arrays.stream(indexKeyFields.split(","))
Review comment:
Can we still split by `:` if your column value has `:` here ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4785: [HUDI-3408] fixed the bug that BUCKET_INDEX cannot process special ch…
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4785:
URL: https://github.com/apache/hudi/pull/4785#issuecomment-1034943901
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ac1b8e67a20b4b891d8a58c212e462ccd9ae8c5c",
"status" : "PENDING",
"url" : "https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5874",
"triggerID" : "ac1b8e67a20b4b891d8a58c212e462ccd9ae8c5c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ac1b8e67a20b4b891d8a58c212e462ccd9ae8c5c Azure: [PENDING](https://dev.azure.com/apache-hudi-ci-org/785b6ef4-2f42-4a89-8f0e-5f0d7039a0cc/_build/results?buildId=5874)
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] hudi-bot commented on pull request #4785: [HUDI-3408] fixed the bug that BUCKET_INDEX cannot process special ch…
Posted by GitBox <gi...@apache.org>.
hudi-bot commented on pull request #4785:
URL: https://github.com/apache/hudi/pull/4785#issuecomment-1034940781
<!--
Meta data
{
"version" : 1,
"metaDataEntries" : [ {
"hash" : "ac1b8e67a20b4b891d8a58c212e462ccd9ae8c5c",
"status" : "UNKNOWN",
"url" : "TBD",
"triggerID" : "ac1b8e67a20b4b891d8a58c212e462ccd9ae8c5c",
"triggerType" : "PUSH"
} ]
}-->
## CI report:
* ac1b8e67a20b4b891d8a58c212e462ccd9ae8c5c UNKNOWN
<details>
<summary>Bot commands</summary>
@hudi-bot supports the following commands:
- `@hudi-bot run azure` re-run the last Azure build
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] minihippo edited a comment on pull request #4785: [HUDI-3408] fixed the bug that BUCKET_INDEX cannot process special ch…
Posted by GitBox <gi...@apache.org>.
minihippo edited a comment on pull request #4785:
URL: https://github.com/apache/hudi/pull/4785#issuecomment-1041505103
>
> @minihippo yes will do it, but i still have some problems, [BucketIdentifier.java](https://github.com/apache/hudi/pull/4785/files#diff-cec97cf4da631039da992f4b6d21424c18a39ced051e2c2faf3739b40b9ebec6) will give a hash value for recordKey, Why don't we just use the hash value of recordkey ？
@xiarixiaoyao Hudi is commonly used to store data warehouse summary tables at ByteDance. Summary table is organized with dimensions and indexes. Id and dimension is composite primary key. Bucket key can be one of the dimension which is frequently aggregated by data analytics to accelerated query.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] minihippo commented on pull request #4785: [HUDI-3408] fixed the bug that BUCKET_INDEX cannot process special ch…
Posted by GitBox <gi...@apache.org>.
minihippo commented on pull request #4785:
URL: https://github.com/apache/hudi/pull/4785#issuecomment-1041505103
>
> @minihippo yes will do it, but i still have some problems, [BucketIdentifier.java](https://github.com/apache/hudi/pull/4785/files#diff-cec97cf4da631039da992f4b6d21424c18a39ced051e2c2faf3739b40b9ebec6) will give a hash value for recordKey, Why don't we just use the hash value of recordkey ？
Hudi is commonly used to store data warehouse summary tables at ByteDance. Summary table is organized with dimensions and indexes. Id and dimension is composite primary key. Bucket key can be one of the dimension which is frequently aggregated by data analytics to accelerated query. In the above scenario, the primary key is a complex type: id and dimension column.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] minihippo commented on pull request #4785: [HUDI-3408] fixed the bug that BUCKET_INDEX cannot process special ch…
Posted by GitBox <gi...@apache.org>.
minihippo commented on pull request #4785:
URL: https://github.com/apache/hudi/pull/4785#issuecomment-1038614467
There is the same problem when column value has ','. Can we use `indexKeyFields` to match and get the value in the hoodiekey?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] danny0405 commented on a change in pull request #4785: [HUDI-3408] fixed the bug that BUCKET_INDEX cannot process special ch…
Posted by GitBox <gi...@apache.org>.
danny0405 commented on a change in pull request #4785:
URL: https://github.com/apache/hudi/pull/4785#discussion_r805482674
##########
File path: hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/bucket/BucketIdentifier.java
##########
@@ -43,7 +43,7 @@ public static int getBucketId(HoodieKey hoodieKey, String indexKeyFields, int nu
} else {
Map<String, String> recordKeyPairs = Arrays.stream(hoodieKey.getRecordKey().split(","))
.map(p -> p.split(":"))
- .collect(Collectors.toMap(p -> p[0], p -> p[1]));
+ .collect(Collectors.toMap(p -> p[0], p -> p.length == 1 ? "" : p[1]));
hashKeyFields = Arrays.stream(indexKeyFields.split(","))
Review comment:
How can a record key be `:::` ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [hudi] xiarixiaoyao commented on pull request #4785: [HUDI-3408] fixed the bug that BUCKET_INDEX cannot process special ch…
Posted by GitBox <gi...@apache.org>.
xiarixiaoyao commented on pull request #4785:
URL: https://github.com/apache/hudi/pull/4785#issuecomment-1038972516
@minihippo yes will do it, but i still have some problems, [BucketIdentifier.java](https://github.com/apache/hudi/pull/4785/files#diff-cec97cf4da631039da992f4b6d21424c18a39ced051e2c2faf3739b40b9ebec6) will give a hash value for recordKey, Why don't we just use the hash value of recordkey ？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org