You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "jscheffl (via GitHub)" <gi...@apache.org> on 2025/06/15 16:13:34 UTC
[PR] Make notes in UI visible directly in header [airflow]
jscheffl opened a new pull request, #51764:
URL: https://github.com/apache/airflow/pull/51764
In Airflow 2 Dag run and Task Instance notes were directly displayed in the details panel. In Airflow 3 UI you needed to click on the modal note button so far.
With this PR the notes are directly displayed on the header card for direct visibility... and can be edited. Button is only displayed to add the note initially.
This is according to the discussion in Slack: https://apache-airflow.slack.com/archives/C0809U4S1Q9/p1747945039343669
New experience on Dag run:
https://github.com/user-attachments/assets/a4f616e6-bacc-4c95-a3d3-60bc25fd4aa6
New experience on Task instances:
https://github.com/user-attachments/assets/8d2b8317-48b6-4181-aa8a-d1439bf5dcd0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Make notes in UI visible directly in header [airflow]
Posted by "jscheffl (via GitHub)" <gi...@apache.org>.
jscheffl commented on PR #51764:
URL: https://github.com/apache/airflow/pull/51764#issuecomment-2977842715
> I am not a big fan of this change. If you have a 200 lines note. Everything will be push down and you'll have to scroll to access the rest of the UI.
Nobody forces you to have 200 lines of note. A note w/ markdown still could carry a `<details>` area which folds. Otherwise I doubt you can make a useful note with 200 lines if the note is limited to 1000 chars atm.
But otherwise: We could also wrap it into a box that has a maximum height of e.g. 200px so that you expand it only to full size if you click on it. Probably there is a component for this... feel free to add it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Make notes in UI visible directly in header [airflow]
Posted by "hussein-awala (via GitHub)" <gi...@apache.org>.
hussein-awala merged PR #51764:
URL: https://github.com/apache/airflow/pull/51764
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Make notes in UI visible directly in header [airflow]
Posted by "bbovenzi (via GitHub)" <gi...@apache.org>.
bbovenzi commented on PR #51764:
URL: https://github.com/apache/airflow/pull/51764#issuecomment-2978335560
Oh this will mess with the outstanding Gantt Chart PR so one of these needs to be rethought. I understand wanting to make notes more obvious. If so, we may need to do the same for dag and task documentation.
At the bare minimum, we should put this inside of an accordion so it can be hidden away
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Make notes in UI visible directly in header [airflow]
Posted by "pierrejeambrun (via GitHub)" <gi...@apache.org>.
pierrejeambrun commented on PR #51764:
URL: https://github.com/apache/airflow/pull/51764#issuecomment-3052089930
This creates an issue with cache invalidation. (Clearing a task with a note, should be reflected directly in the component, but because of the local state, it keeps the old value)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org