You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by GitBox <gi...@apache.org> on 2020/07/22 22:26:40 UTC
[GitHub] [camel-website] zregvart commented on a change in pull request #434: feat: add github action for image optimization
zregvart commented on a change in pull request #434:
URL: https://github.com/apache/camel-website/pull/434#discussion_r459118698
##########
File path: .github/workflows/calibreapp-image-actions.yml
##########
@@ -0,0 +1,20 @@
+name: Compress images
+on: pull_request
+jobs:
+ build:
+ name: calibreapp/image-actions
+ runs-on: ubuntu-latest
+ steps:
+ - name: Checkout
+ uses: actions/checkout@master
+
+ - name: Compress Images
+ uses: calibreapp/image-actions@master
+ with:
+ githubToken: ${{ secrets.GITHUB_TOKEN }}
+ jpegQuality: "80"
+ jpegProgressive: false
+ pngQuality: "80"
+ webpQuality: "80"
+ ignorePaths: "node_modules/**,build"
Review comment:
I don't think we need this we don't have node_modules nor build directories. Would this include only `public`?
```suggestion
ignorePaths: "!public"
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org