You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2018/04/16 21:46:18 UTC
[kudu-CR] hms client-test: tweak large object batch size
Hello Adar Dembo,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/10081
to review the following change.
Change subject: hms_client-test: tweak large object batch size
......................................................................
hms_client-test: tweak large object batch size
Some test environments were having issues with this test depending on
their path layout. Long test tmp dir paths would push derby over some
kind of internal data size limit. The fix is to use more, smaller
batches.
Change-Id: I51abe01eb3f5b0226dc289ae0f2ade27b10d701b
---
M src/kudu/hms/hms_client-test.cc
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/81/10081/1
--
To view, visit http://gerrit.cloudera.org:8080/10081
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I51abe01eb3f5b0226dc289ae0f2ade27b10d701b
Gerrit-Change-Number: 10081
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
[kudu-CR] hms client-test: tweak large object batch size
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change. ( http://gerrit.cloudera.org:8080/10081 )
Change subject: hms_client-test: tweak large object batch size
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/10081
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I51abe01eb3f5b0226dc289ae0f2ade27b10d701b
Gerrit-Change-Number: 10081
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Mon, 16 Apr 2018 22:17:52 +0000
Gerrit-HasComments: No
[kudu-CR] hms client-test: tweak large object batch size
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/10081 )
Change subject: hms_client-test: tweak large object batch size
......................................................................
hms_client-test: tweak large object batch size
Some test environments were having issues with this test depending on
their path layout. Long test tmp dir paths would push derby over some
kind of internal data size limit. The fix is to use more, smaller
batches.
Change-Id: I51abe01eb3f5b0226dc289ae0f2ade27b10d701b
Reviewed-on: http://gerrit.cloudera.org:8080/10081
Tested-by: Kudu Jenkins
Reviewed-by: Adar Dembo <ad...@cloudera.com>
---
M src/kudu/hms/hms_client-test.cc
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Kudu Jenkins: Verified
Adar Dembo: Looks good to me, approved
--
To view, visit http://gerrit.cloudera.org:8080/10081
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I51abe01eb3f5b0226dc289ae0f2ade27b10d701b
Gerrit-Change-Number: 10081
Gerrit-PatchSet: 2
Gerrit-Owner: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins