[GitHub] [beam] youngoli commented on issue #11257: [BEAM-3301] Create runtime invokers for SDF methods.

[GitBox <gi...@apache.org>]

youngoli commented on issue #11257: [BEAM-3301] Create runtime invokers for SDF methods.
URL: https://github.com/apache/beam/pull/11257#issuecomment-605409185
 
 
   CC: @lostluck 
   
   Like I mentioned in the commit message above, this is lacking runtime optimizations. I got the testing working and wanted to get this in a PR so you can give some general feedback so I can know if I'm on the right track. But as-is, the change isn't done yet.
   
   My current plan for optimization is to follow the regular invoker's example and make this a method we can call in Setup, have it output a CallFn, and then we can use that in ProcessElement to actually invoke the method, without the extra boilerplate that doesn't need to be done per-element. I avoided all that for the first go-round because I didn't understand why it was being done that way, and I just wanted the simplest implementation possible to get it working.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services