[GitHub] [druid] github-code-scanning[bot] commented on a diff in pull request #13955: Always use file sizes when determining batch ingest splits

["github-code-scanning[bot] (via GitHub)" <gi...@apache.org>]

github-code-scanning[bot] commented on code in PR #13955:
URL: https://github.com/apache/druid/pull/13955#discussion_r1142835353


##########
extensions-contrib/aliyun-oss-extensions/src/test/java/org/apache/druid/data/input/aliyun/OssInputSourceTest.java:
##########
@@ -683,4 +697,11 @@
       throw new UnsupportedOperationException();
     }
   }
+
+  private static ObjectMetadata objectMetadataWithSize(final CloudObjectLocation location, final long size)

Review Comment:
   ## Useless parameter
   
   The parameter 'location' is never used.
   
   [Show more details](https://github.com/apache/druid/security/code-scanning/4414)



##########
extensions-core/s3-extensions/src/main/java/org/apache/druid/data/input/s3/S3InputSource.java:
##########
@@ -391,27 +404,34 @@
            '}';
   }
 
-  private Iterable<S3ObjectSummary> getIterableObjectsFromPrefixes()
+  private static class ObjectDescriptor

Review Comment:
   ## Unused classes and interfaces
   
   Unused class: ObjectDescriptor is not referenced within this codebase. If not used as an external API it should be removed.
   
   [Show more details](https://github.com/apache/druid/security/code-scanning/4412)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org