[GitHub] mistercrunch edited a comment on issue #6912: Remove Cypress from package.json

[GitBox <gi...@apache.org>]

mistercrunch edited a comment on issue #6912: Remove Cypress from package.json
URL: https://github.com/apache/incubator-superset/pull/6912#issuecomment-467588453
 
 
   I think this is important. Cypress is a very large package and installing/uninstalling a 500mb+ compressed thing is really bad for CI and docker image bloat... 
   
   For context, and for people less familiar docker, each docker command in a Dockerfile adds an immutable layer to your docker file, and each layer is more or less a filesystem diff from the previous immutable layer. Even if I `RUN npm ci && npm uininstall cypress` I have the issue that cypress stays burried in npm's cache (somewhere under `~/.npm`). Running cache free is not really an option as I want this cache in my `Dockerfile.build` target. Note that even if I could clear the cache, `npm ci` does waste time / network downloading and unzipping 500mb which takes minutes in an underpowered container. My only other options would be to maintain a cherry or mutate the package.json with `awk` prior to running `npm ci`, which is pretty nasty.
   
   For all these reasons I vote to merge this PR, and live with cypress as something we install on-demand / need.
   
   ![container](https://user-images.githubusercontent.com/487433/53442934-4d4dec80-39bf-11e9-8ebc-8c00f10b46e6.jpg)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org