You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/11/16 15:26:50 UTC

[GitHub] [hudi] sbernauer commented on a change in pull request #2208: [HUDI-1040] Make Hudi support Spark 3

sbernauer commented on a change in pull request #2208:
URL: https://github.com/apache/hudi/pull/2208#discussion_r524351032



##########
File path: hudi-spark/src/main/scala/org/apache/hudi/HoodieSparkSqlWriter.scala
##########
@@ -121,6 +122,9 @@ private[hudi] object HoodieSparkSqlWriter {
       // short-circuit if bulk_insert via row is enabled.
       // scalastyle:off
       if (parameters(ENABLE_ROW_WRITER_OPT_KEY).toBoolean) {
+        if (SPARK_VERSION.startsWith("3.")) {

Review comment:
       Hi, checking for `if (!SPARK_VERSION.startsWith("2.")) {` would be more robust because of future relases (e.g. Spark 4)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org