You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@hbase.apache.org by "Jingcheng Du (JIRA)" <ji...@apache.org> on 2017/12/28 05:44:00 UTC

[jira] [Commented] (HBASE-19650) ExpiredMobFileCleaner has wrong logic about TTL check

    [ https://issues.apache.org/jira/browse/HBASE-19650?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16305076#comment-16305076 ] 

Jingcheng Du commented on HBASE-19650:
--------------------------------------

Thanks for the patch [~javaman_chen].
You encounter this issue when you run the mob file cleaner? Or do you have test to re-produce this case?
As far as I know, it won't happen. The comparison is based on date, the hour/minute/second are not included. In your description, the file date and expired date are 2017-12-27, and the files in 2017-12-27 won't be archived.

> ExpiredMobFileCleaner has wrong logic about TTL check
> -----------------------------------------------------
>
>                 Key: HBASE-19650
>                 URL: https://issues.apache.org/jira/browse/HBASE-19650
>             Project: HBase
>          Issue Type: Bug
>          Components: mob
>            Reporter: chenxu
>            Assignee: chenxu
>         Attachments: HBASE-19650-master-v1.patch
>
>
> If today is 2017-12-28 00:00:01, and TTL is set to 86400, when MobUtils.cleanExpiredMobFiles execute, expireDate will be 1514304000749, but fileDate is 1514304000000. So the fileDate before the expireDate and mobfiles generated in is 2017-12-27 will all are deleted. But in fact, we want to delete files before 2017-12-27.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)