You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Roland Weber (JIRA)" <ji...@apache.org> on 2007/09/01 18:25:18 UTC
[jira] Created: (HTTPCLIENT-689) stackable parameters
stackable parameters
--------------------
Key: HTTPCLIENT-689
URL: https://issues.apache.org/jira/browse/HTTPCLIENT-689
Project: HttpComponents HttpClient
Issue Type: Improvement
Reporter: Roland Weber
Assignee: Roland Weber
Priority: Minor
Fix For: 4.0 Alpha 2
Implement "stackable parameters" to allow for a parameter hierarchy without linking params instances.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org
[jira] Commented: (HTTPCLIENT-689) stackable parameters
Posted by "Oleg Kalnichevski (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12532954 ]
Oleg Kalnichevski commented on HTTPCLIENT-689:
----------------------------------------------
Looks good to me.
Oleg
> stackable parameters
> --------------------
>
> Key: HTTPCLIENT-689
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-689
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Reporter: Roland Weber
> Assignee: Roland Weber
> Priority: Minor
> Fix For: 4.0 Alpha 2
>
>
> Implement "stackable parameters" to allow for a parameter hierarchy without linking params instances.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org
[jira] Commented: (HTTPCLIENT-689) stackable parameters
Posted by "Roland Weber (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-689?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12529685 ]
Roland Weber commented on HTTPCLIENT-689:
-----------------------------------------
I've created a class o.a.h.impl.client.ClientParamsStack and changed DefaultClientRequestDirector to use that instead of HttpParamsLinker. The calls to HPLinker are still in the source code as comments, so you can easily locate the changes.
The next step would be to move the stack-building from the director to the client, and to drop the params attribute from the director. The director should take it's parameters from the stack that comes with the request. I'll wait with that until the first step is reviewed.
cheers,
Roland
> stackable parameters
> --------------------
>
> Key: HTTPCLIENT-689
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-689
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Reporter: Roland Weber
> Assignee: Roland Weber
> Priority: Minor
> Fix For: 4.0 Alpha 2
>
>
> Implement "stackable parameters" to allow for a parameter hierarchy without linking params instances.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org
[jira] Resolved: (HTTPCLIENT-689) stackable parameters
Posted by "Roland Weber (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/HTTPCLIENT-689?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Roland Weber resolved HTTPCLIENT-689.
-------------------------------------
Resolution: Fixed
I've slightly revised my plan for the next step. Parameter stack building is moved to AbstractHttpClient,
but the DefaultClientRequestDirector keeps it's params attribute and constructor argument. Instead
of the plain client parameters, it is initialized with the params stack created by the client.
On first glance, it seems to me that the behavior of the director becomes more predictable this way.
It doesn't switch between using client-only params and the params stack created for the request.
cheers,
Roland
> stackable parameters
> --------------------
>
> Key: HTTPCLIENT-689
> URL: https://issues.apache.org/jira/browse/HTTPCLIENT-689
> Project: HttpComponents HttpClient
> Issue Type: Improvement
> Reporter: Roland Weber
> Assignee: Roland Weber
> Priority: Minor
> Fix For: 4.0 Alpha 2
>
>
> Implement "stackable parameters" to allow for a parameter hierarchy without linking params instances.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: httpcomponents-dev-unsubscribe@jakarta.apache.org
For additional commands, e-mail: httpcomponents-dev-help@jakarta.apache.org