You are viewing a plain text version of this content. The canonical link for it is here.
Posted to bugs@httpd.apache.org by Bruno Raoult <br...@gmail.com> on 2016/02/29 13:31:10 UTC
Bug 57227 - Patch still not in main stream
Hi,
I did find a bug in mod_autoindex more than one year ago, about missing CSS
class, and proposed a patch at same time (
https://bz.apache.org/bugzilla/show_bug.cgi?id=57227).
It appears that this patch is still not applied in recent versions.
I think there must be a kind of validation (and/or votes) to go further, I
am not 100% sure about the process. What should I do to have someone
looking at it (so there is a positive or negative action), so that I don't
have to recompile the module each time I get a new apache release in my
favourite distribution?
Thanks,
br.
--
2 + 2 = 5, for very large values of 2.
Re: Bug 57227 - Patch still not in main stream
Posted by Yann Ylavic <yl...@gmail.com>.
On Mon, Feb 29, 2016 at 5:01 PM, Jim Jagielski <ji...@jagunet.com> wrote:
>
>> On Feb 29, 2016, at 7:43 AM, Yann Ylavic <yl...@gmail.com> wrote:
>>
>> Hi,
>>
>> On Mon, Feb 29, 2016 at 1:31 PM, Bruno Raoult <br...@gmail.com> wrote:
>>>
>>> I did find a bug in mod_autoindex more than one year ago, about missing CSS
>>> class, and proposed a patch at same time
>>> (https://bz.apache.org/bugzilla/show_bug.cgi?id=57227).
>>> It appears that this patch is still not applied in recent versions.
>>
>> It seems that it was merge in version 2.4.12, with
>> http://svn.apache.org/r1651644 (no changelog associated, though).
>>
>
> There was no changelog entry in the orig patch, hence none
> in the backport.
Yes, I know, maybe we should be more strict about this at backport
time, dunno...
It would be more work for the proposer/backporter, sometimes the trunk
commits were not meant to be backported anytime soon, and don't
contain the CHANGES entry (not provided by the original committer).
But we are not so bad wrt this generally, and anyway too much
procedure isn't ideal either, it may still happen one day or
another...
Re: Bug 57227 - Patch still not in main stream
Posted by Jim Jagielski <ji...@jaguNET.com>.
> On Feb 29, 2016, at 7:43 AM, Yann Ylavic <yl...@gmail.com> wrote:
>
> Hi,
>
> On Mon, Feb 29, 2016 at 1:31 PM, Bruno Raoult <br...@gmail.com> wrote:
>>
>> I did find a bug in mod_autoindex more than one year ago, about missing CSS
>> class, and proposed a patch at same time
>> (https://bz.apache.org/bugzilla/show_bug.cgi?id=57227).
>> It appears that this patch is still not applied in recent versions.
>
> It seems that it was merge in version 2.4.12, with
> http://svn.apache.org/r1651644 (no changelog associated, though).
>
There was no changelog entry in the orig patch, hence none
in the backport.
Re: Bug 57227 - Patch still not in main stream
Posted by Yann Ylavic <yl...@gmail.com>.
On Mon, Feb 29, 2016 at 3:55 PM, Yann Ylavic <yl...@gmail.com> wrote:
>
> On Mon, Feb 29, 2016 at 2:52 PM, Bruno Raoult <br...@gmail.com> wrote:
>>
>> In order to find out by myself next time, how did you jump from r1648201
>> (which I
>> found from my bug/patch report) to r1651644 and then to 2.4.12 ?
>> I am missing some steps for sure.
>
> Otherwise I think the safest way is to search the trunk commit
> reference (r1648201 here) either on google (something like "httpd
> 2.4.x merge r1648201", but it does not seem to help here) or better in
> the commit messages of the 2.4.x branch (that is in the output of: svn
> log -v http://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x),
> which points to r1651644 here.
> Not very friendly but it works since each commit in a stable branch
> contains the reference of the original (merged) commit in trunk...
A more friendly way could be to search for r1648201 in
http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/modules/generators/mod_autoindex.c?view=log,
since you know the changed file here, or use the root path
(.../viewvc/httpd/httpd/branches/2.4.x/?view=log) if you really don't
have such information (it takes longer to compute the result, though).
Hope this helps better.
Re: Bug 57227 - Patch still not in main stream
Posted by Yann Ylavic <yl...@gmail.com>.
On Mon, Feb 29, 2016 at 3:55 PM, Yann Ylavic <yl...@gmail.com> wrote:
>
> On Mon, Feb 29, 2016 at 2:52 PM, Bruno Raoult <br...@gmail.com> wrote:
>>
>> In order to find out by myself next time, how did you jump from r1648201
>> (which I
>> found from my bug/patch report) to r1651644 and then to 2.4.12 ?
>> I am missing some steps for sure.
>
> Otherwise I think the safest way is to search the trunk commit
> reference (r1648201 here) either on google (something like "httpd
> 2.4.x merge r1648201", but it does not seem to help here) or better in
> the commit messages of the 2.4.x branch (that is in the output of: svn
> log -v http://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x),
> which points to r1651644 here.
> Not very friendly but it works since each commit in a stable branch
> contains the reference of the original (merged) commit in trunk...
A more friendly way could be to search for r1648201 in
http://svn.apache.org/viewvc/httpd/httpd/branches/2.4.x/modules/generators/mod_autoindex.c?view=log,
since you know the changed file here, or use the root path
(.../viewvc/httpd/httpd/branches/2.4.x/?view=log) if you really don't
have such information (it takes longer to compute the result, though).
Hope this helps better.
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
Re: Bug 57227 - Patch still not in main stream
Posted by Yann Ylavic <yl...@gmail.com>.
[CCing the original bugs@ list and dev@ which I somehow added from my
first response.
Not sure bugs@ is to be addressed directly though, it is normally CCed
for bugzilla reports only...]
On Mon, Feb 29, 2016 at 2:52 PM, Bruno Raoult <br...@gmail.com> wrote:
>
>> On Mon, Feb 29, 2016 at 1:31 PM, Bruno Raoult <br...@gmail.com> wrote:
>> >
>> > I did find a bug in mod_autoindex more than one year ago, about missing
>> > CSS
>> > class, and proposed a patch at same time
>> > (https://bz.apache.org/bugzilla/show_bug.cgi?id=57227).
>> > It appears that this patch is still not applied in recent versions.
>>
>> It seems that it was merge in version 2.4.12, with
>> http://svn.apache.org/r1651644 (no changelog associated, though).
>
> It was indeed (just checked on my latest Ubuntu desktop, which has 2.4.12).
>
> In order to find out by myself next time, how did you jump from r1648201
> (which I
> found from my bug/patch report) to r1651644 and then to 2.4.12 ?
> I am missing some steps for sure.
I guess the easiest way would have been a CHANGES entry, and/or the
merge commit referenced in the bugzilla report (this is usually the
case, but not here...).
Personnaly I just searched r1648201 in my mailbox history which
pointed out to the merge in r1651644, but I'm subscribed to the cvs@
list (as a committer).
Otherwise I think the safest way is to search the trunk commit
reference (r1648201 here) either on google (something like "httpd
2.4.x merge r1648201", but it does not seem to help here) or better in
the commit messages of the 2.4.x branch (that is in the output of: svn
log -v http://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x),
which points to r1651644 here.
Not very friendly but it works since each commit in a stable branch
contains the reference of the original (merged) commit in trunk...
For the release number (here 2.4.12), I compared the date of the
commit r1651644 in 2.4.x (still given by the "svn log ..." command
above) with the ones of the releases (maintained in the STATUS file of
each branch, eg: svn cat
http://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x/STATUS),
2.4.12 being the next version released (2.4.11 wasn't) after "Wed, Jan
14 2015" (the date of r1651644).
Hope this helps :p
---------------------------------------------------------------------
To unsubscribe, e-mail: bugs-unsubscribe@httpd.apache.org
For additional commands, e-mail: bugs-help@httpd.apache.org
Re: Bug 57227 - Patch still not in main stream
Posted by Yann Ylavic <yl...@gmail.com>.
[CCing the original bugs@ list and dev@ which I somehow added from my
first response.
Not sure bugs@ is to be addressed directly though, it is normally CCed
for bugzilla reports only...]
On Mon, Feb 29, 2016 at 2:52 PM, Bruno Raoult <br...@gmail.com> wrote:
>
>> On Mon, Feb 29, 2016 at 1:31 PM, Bruno Raoult <br...@gmail.com> wrote:
>> >
>> > I did find a bug in mod_autoindex more than one year ago, about missing
>> > CSS
>> > class, and proposed a patch at same time
>> > (https://bz.apache.org/bugzilla/show_bug.cgi?id=57227).
>> > It appears that this patch is still not applied in recent versions.
>>
>> It seems that it was merge in version 2.4.12, with
>> http://svn.apache.org/r1651644 (no changelog associated, though).
>
> It was indeed (just checked on my latest Ubuntu desktop, which has 2.4.12).
>
> In order to find out by myself next time, how did you jump from r1648201
> (which I
> found from my bug/patch report) to r1651644 and then to 2.4.12 ?
> I am missing some steps for sure.
I guess the easiest way would have been a CHANGES entry, and/or the
merge commit referenced in the bugzilla report (this is usually the
case, but not here...).
Personnaly I just searched r1648201 in my mailbox history which
pointed out to the merge in r1651644, but I'm subscribed to the cvs@
list (as a committer).
Otherwise I think the safest way is to search the trunk commit
reference (r1648201 here) either on google (something like "httpd
2.4.x merge r1648201", but it does not seem to help here) or better in
the commit messages of the 2.4.x branch (that is in the output of: svn
log -v http://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x),
which points to r1651644 here.
Not very friendly but it works since each commit in a stable branch
contains the reference of the original (merged) commit in trunk...
For the release number (here 2.4.12), I compared the date of the
commit r1651644 in 2.4.x (still given by the "svn log ..." command
above) with the ones of the releases (maintained in the STATUS file of
each branch, eg: svn cat
http://svn.apache.org/repos/asf/httpd/httpd/branches/2.4.x/STATUS),
2.4.12 being the next version released (2.4.11 wasn't) after "Wed, Jan
14 2015" (the date of r1651644).
Hope this helps :p
Re: Bug 57227 - Patch still not in main stream
Posted by Yann Ylavic <yl...@gmail.com>.
Hi,
On Mon, Feb 29, 2016 at 1:31 PM, Bruno Raoult <br...@gmail.com> wrote:
>
> I did find a bug in mod_autoindex more than one year ago, about missing CSS
> class, and proposed a patch at same time
> (https://bz.apache.org/bugzilla/show_bug.cgi?id=57227).
> It appears that this patch is still not applied in recent versions.
It seems that it was merge in version 2.4.12, with
http://svn.apache.org/r1651644 (no changelog associated, though).
Regards,
Yann.