You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Pallavi Rao <pa...@inmobi.com> on 2016/01/18 13:21:39 UTC
Review Request 42455: FALCON-1754 JobCompletionService throws
FalconException
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42455/
-----------------------------------------------------------
Review request for Falcon.
Bugs: FALCON-1754
https://issues.apache.org/jira/browse/FALCON-1754
Repository: falcon-git
Description
-------
The Service should continue to notify other handlers on exception
Diffs
-----
scheduler/src/main/java/org/apache/falcon/notification/service/impl/JobCompletionService.java 4278d3f
Diff: https://reviews.apache.org/r/42455/diff/
Testing
-------
Thanks,
Pallavi Rao
Re: Review Request 42455: FALCON-1754 JobCompletionService throws
FalconException
Posted by Pallavi Rao <pa...@inmobi.com>.
> On Jan. 22, 2016, 12:15 p.m., Praveen Adlakha wrote:
> > scheduler/src/main/java/org/apache/falcon/notification/service/impl/JobCompletionService.java, line 159
> > <https://reviews.apache.org/r/42455/diff/2/?file=1205563#file1205563line159>
> >
> > IMO we should ideally be doing two catches here one for EntityNotRegisteredException which will print the exception in log and other catch statement will catch FalconException and will do nothing.
oops. yes. fixed.
- Pallavi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42455/#review115828
-----------------------------------------------------------
On Jan. 22, 2016, 11:29 a.m., Pallavi Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42455/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2016, 11:29 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1754
> https://issues.apache.org/jira/browse/FALCON-1754
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> The Service should continue to notify other handlers on exception
>
>
> Diffs
> -----
>
> scheduler/src/main/java/org/apache/falcon/execution/FalconExecutionService.java 7bdcd6f
> scheduler/src/main/java/org/apache/falcon/notification/service/impl/JobCompletionService.java 4278d3f
>
> Diff: https://reviews.apache.org/r/42455/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Pallavi Rao
>
>
Re: Review Request 42455: FALCON-1754 JobCompletionService throws
FalconException
Posted by Praveen Adlakha <ad...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42455/#review115828
-----------------------------------------------------------
scheduler/src/main/java/org/apache/falcon/notification/service/impl/JobCompletionService.java (line 159)
<https://reviews.apache.org/r/42455/#comment176896>
IMO we should ideally be doing two catches here one for EntityNotRegisteredException which will print the exception in log and other catch statement will catch FalconException and will do nothing.
- Praveen Adlakha
On Jan. 22, 2016, 11:29 a.m., Pallavi Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42455/
> -----------------------------------------------------------
>
> (Updated Jan. 22, 2016, 11:29 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1754
> https://issues.apache.org/jira/browse/FALCON-1754
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> The Service should continue to notify other handlers on exception
>
>
> Diffs
> -----
>
> scheduler/src/main/java/org/apache/falcon/execution/FalconExecutionService.java 7bdcd6f
> scheduler/src/main/java/org/apache/falcon/notification/service/impl/JobCompletionService.java 4278d3f
>
> Diff: https://reviews.apache.org/r/42455/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Pallavi Rao
>
>
Re: Review Request 42455: FALCON-1754 JobCompletionService throws
FalconException
Posted by Pallavi Rao <pa...@inmobi.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42455/
-----------------------------------------------------------
(Updated Jan. 22, 2016, 11:29 a.m.)
Review request for Falcon.
Changes
-------
Updated patch to ignore specific exception.
Bugs: FALCON-1754
https://issues.apache.org/jira/browse/FALCON-1754
Repository: falcon-git
Description
-------
The Service should continue to notify other handlers on exception
Diffs (updated)
-----
scheduler/src/main/java/org/apache/falcon/execution/FalconExecutionService.java 7bdcd6f
scheduler/src/main/java/org/apache/falcon/notification/service/impl/JobCompletionService.java 4278d3f
Diff: https://reviews.apache.org/r/42455/diff/
Testing
-------
Thanks,
Pallavi Rao
Re: Review Request 42455: FALCON-1754 JobCompletionService throws
FalconException
Posted by Pallavi Rao <pa...@inmobi.com>.
> On Jan. 22, 2016, 5:54 a.m., Praveen Adlakha wrote:
> > scheduler/src/main/java/org/apache/falcon/notification/service/impl/JobCompletionService.java, line 160
> > <https://reviews.apache.org/r/42455/diff/1/?file=1200183#file1200183line160>
> >
> > We should use either LOG.info or LOG.error in this case.
> > LOG.info if we intend to do nothing because debug mode will not be enabled every time.
It is getting logged currently and Pragya says it is noise. Hence was planning to move it to debug. But, honestly, I don't myself like the idea of hiding exception indiscriminately. Let me upload a new patch
- Pallavi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42455/#review115790
-----------------------------------------------------------
On Jan. 18, 2016, 12:21 p.m., Pallavi Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42455/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2016, 12:21 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1754
> https://issues.apache.org/jira/browse/FALCON-1754
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> The Service should continue to notify other handlers on exception
>
>
> Diffs
> -----
>
> scheduler/src/main/java/org/apache/falcon/notification/service/impl/JobCompletionService.java 4278d3f
>
> Diff: https://reviews.apache.org/r/42455/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Pallavi Rao
>
>
Re: Review Request 42455: FALCON-1754 JobCompletionService throws
FalconException
Posted by Praveen Adlakha <ad...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/42455/#review115790
-----------------------------------------------------------
scheduler/src/main/java/org/apache/falcon/notification/service/impl/JobCompletionService.java (line 160)
<https://reviews.apache.org/r/42455/#comment176847>
We should use either LOG.info or LOG.error in this case.
LOG.info if we intend to do nothing because debug mode will not be enabled every time.
- Praveen Adlakha
On Jan. 18, 2016, 12:21 p.m., Pallavi Rao wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/42455/
> -----------------------------------------------------------
>
> (Updated Jan. 18, 2016, 12:21 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1754
> https://issues.apache.org/jira/browse/FALCON-1754
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> The Service should continue to notify other handlers on exception
>
>
> Diffs
> -----
>
> scheduler/src/main/java/org/apache/falcon/notification/service/impl/JobCompletionService.java 4278d3f
>
> Diff: https://reviews.apache.org/r/42455/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Pallavi Rao
>
>