You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ant.apache.org by jaikiran <gi...@git.apache.org> on 2017/12/12 11:27:30 UTC
[GitHub] ant pull request #51: [master] Changes for BZ-19516
GitHub user jaikiran opened a pull request:
https://github.com/apache/ant/pull/51
[master] Changes for BZ-19516
As suggested in https://bz.apache.org/bugzilla/show_bug.cgi?id=19516, the change in this PR uses `java.io.BufferedInputStream` which can take an underlying `InputStream` and provide `mark` support on the input stream. This should prevent loading a large amount of data into memory, in certain cases, in the `Zip` task.
If this PR is approved, I'll then backport this pretty straightforward change to 1.9.x branch too.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jaikiran/ant bz-19516-master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ant/pull/51.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #51
----
commit 759a9c1263e8bb0a710c638960756af2e0971bc4
Author: Jaikiran Pai <ja...@gmail.com>
Date: 2017-12-12T11:22:26Z
BZ-19516 Use BufferedInputStream for reduced memory usage in Zip task, in certain cases
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] ant issue #51: [master] Changes for BZ-19516
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/ant/pull/51
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ant-1.9.x%20Github-PR-Windows/7/
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] ant pull request #51: [master] Changes for BZ-19516
Posted by jaikiran <gi...@git.apache.org>.
GitHub user jaikiran reopened a pull request:
https://github.com/apache/ant/pull/51
[master] Changes for BZ-19516
As suggested in https://bz.apache.org/bugzilla/show_bug.cgi?id=19516, the change in this PR uses `java.io.BufferedInputStream` which can take an underlying `InputStream` and provide `mark` support on the input stream. This should prevent loading a large amount of data into memory, in certain cases, in the `Zip` task.
If this PR is approved, I'll then backport this pretty straightforward change to 1.9.x branch too.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jaikiran/ant bz-19516-master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ant/pull/51.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #51
----
commit 759a9c1263e8bb0a710c638960756af2e0971bc4
Author: Jaikiran Pai <ja...@gmail.com>
Date: 2017-12-12T11:22:26Z
BZ-19516 Use BufferedInputStream for reduced memory usage in Zip task, in certain cases
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] ant issue #51: [master] Changes for BZ-19516
Posted by jaikiran <gi...@git.apache.org>.
Github user jaikiran commented on the issue:
https://github.com/apache/ant/pull/51
retest this please
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] ant issue #51: [master] Changes for BZ-19516
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/ant/pull/51
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ant%20Github-PR-Linux/1/
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] ant issue #51: [master] Changes for BZ-19516
Posted by jaikiran <gi...@git.apache.org>.
Github user jaikiran commented on the issue:
https://github.com/apache/ant/pull/51
>> an alternative would be to only wrap the stream inside of zipFile if mark wasn't supported.
@bodewig, I actually liked your idea. So I did an additional change in this commit (PR has been updated) to wrap the incoming stream into a stream that supports marking, if the incoming one doesn't. That way, it takes into account input streams that this `Zip` class doesn't construct and instead is passed to this method.
Please take a look at the updated PR and let me know what you think.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] ant issue #51: [master] Changes for BZ-19516
Posted by jaikiran <gi...@git.apache.org>.
Github user jaikiran commented on the issue:
https://github.com/apache/ant/pull/51
retest this please
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] ant pull request #51: [master] Changes for BZ-19516
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/ant/pull/51
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] ant pull request #51: [master] Changes for BZ-19516
Posted by jaikiran <gi...@git.apache.org>.
Github user jaikiran closed the pull request at:
https://github.com/apache/ant/pull/51
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] ant issue #51: [master] Changes for BZ-19516
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/ant/pull/51
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ant-Master%20Github-PR-Windows/2/
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] ant pull request #51: [master] Changes for BZ-19516
Posted by jaikiran <gi...@git.apache.org>.
GitHub user jaikiran reopened a pull request:
https://github.com/apache/ant/pull/51
[master] Changes for BZ-19516
As suggested in https://bz.apache.org/bugzilla/show_bug.cgi?id=19516, the change in this PR uses `java.io.BufferedInputStream` which can take an underlying `InputStream` and provide `mark` support on the input stream. This should prevent loading a large amount of data into memory, in certain cases, in the `Zip` task.
If this PR is approved, I'll then backport this pretty straightforward change to 1.9.x branch too.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/jaikiran/ant bz-19516-master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/ant/pull/51.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #51
----
commit 759a9c1263e8bb0a710c638960756af2e0971bc4
Author: Jaikiran Pai <ja...@gmail.com>
Date: 2017-12-12T11:22:26Z
BZ-19516 Use BufferedInputStream for reduced memory usage in Zip task, in certain cases
----
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] ant issue #51: [master] Changes for BZ-19516
Posted by bodewig <gi...@git.apache.org>.
Github user bodewig commented on the issue:
https://github.com/apache/ant/pull/51
an alternative would be to only wrap the stream inside of `zipFile` if `mark` wasn't supported. But I'm fine with the change as it is.
Thank you for dusting of really old issues.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] ant issue #51: [master] Changes for BZ-19516
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/ant/pull/51
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ant%20Github-PR-Windows/8/
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] ant issue #51: [master] Changes for BZ-19516
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/ant/pull/51
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ant-Master%20Github-PR-Windows/4/
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] ant issue #51: [master] Changes for BZ-19516
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/ant/pull/51
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ant-1.9.x%20Github-PR-Windows/8/
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] ant pull request #51: [master] Changes for BZ-19516
Posted by jaikiran <gi...@git.apache.org>.
Github user jaikiran closed the pull request at:
https://github.com/apache/ant/pull/51
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] ant issue #51: [master] Changes for BZ-19516
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit commented on the issue:
https://github.com/apache/ant/pull/51
Refer to this link for build results (access rights to CI server needed):
https://builds.apache.org/job/Ant-Master%20Github-PR-Windows/7/
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] ant issue #51: [master] Changes for BZ-19516
Posted by jaikiran <gi...@git.apache.org>.
Github user jaikiran commented on the issue:
https://github.com/apache/ant/pull/51
Thanks for reviewing. Merged to master branch. Will backport it to 1.9.x too.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org
[GitHub] ant issue #51: [master] Changes for BZ-19516
Posted by bodewig <gi...@git.apache.org>.
Github user bodewig commented on the issue:
https://github.com/apache/ant/pull/51
Looks good to me.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@ant.apache.org
For additional commands, e-mail: dev-help@ant.apache.org