You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2021/01/22 22:21:12 UTC
[GitHub] [geode-native] moleske opened a new pull request #728: Fix LGTM Usless Variable Assigment in C# files
moleske opened a new pull request #728:
URL: https://github.com/apache/geode-native/pull/728
Draft cause there's a lot of them. Also opening this pr so that lgtm can run through it.
Also if anyone is reading this, my Windows CI seems to have become sad because of
[`error MSB8036: The Windows SDK version 10.0.14393 was not found. Install the required version of Windows SDK or change the SDK version in the project property pages or by right-clicking the solution and selecting "Retarget solution"`](https://github.com/moleske/geode-native/runs/1691403365?check_suite_focus=true#step:11:270)
in building ACE. Did something change that I missed? Was using Visual Studio 2017, should be trying to add that SDK version in Visual Studio installer?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] lgtm-com[bot] commented on pull request #728: Fix LGTM Usless Variable Assigment in C# files
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #728:
URL: https://github.com/apache/geode-native/pull/728#issuecomment-774240260
This pull request **fixes 170 alerts** when merging 73f3a7e60710a50ff9fde9a501ff9a4a2b0cde7a into 798aafb8e43536a07a809940a05cdd846d94cc93 - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode-native/rev/pr-3af1b9fc31090550545bf42d4dc7fc3643f76775)
**fixed alerts:**
* 170 for Useless assignment to local variable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] lgtm-com[bot] commented on pull request #728: Fix LGTM Usless Variable Assigment in C# files
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #728:
URL: https://github.com/apache/geode-native/pull/728#issuecomment-765873906
This pull request **fixes 170 alerts** when merging 0075d462355dcfe6d86b8b43f1239c0577d56e45 into bc3fa6bffb5ffc476260db0820e83fdec3b341d2 - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode-native/rev/pr-e936e88c28eda3665e49b00defc3db9edaf419a0)
**fixed alerts:**
* 170 for Useless assignment to local variable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] lgtm-com[bot] commented on pull request #728: Fix LGTM Usless Variable Assigment in C# files
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #728:
URL: https://github.com/apache/geode-native/pull/728#issuecomment-765805998
This pull request **introduces 3 alerts** and **fixes 206** when merging 110351b8705ab3b5c73e954b04266ef7917f4ac0 into bc3fa6bffb5ffc476260db0820e83fdec3b341d2 - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode-native/rev/pr-68ec93f8ec0cb0835064a7394a7f08b8a71e7698)
**new alerts:**
* 3 for Useless assignment to local variable
**fixed alerts:**
* 206 for Useless assignment to local variable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] lgtm-com[bot] commented on pull request #728: Fix LGTM Usless Variable Assigment in C# files
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #728:
URL: https://github.com/apache/geode-native/pull/728#issuecomment-767229873
This pull request **fixes 170 alerts** when merging a130467c51a784b34b9aa4082abaf7078fb76454 into 9a46e7d89918c192c3edd5ff57dbfee078419883 - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode-native/rev/pr-030a2de7b7c666dec008df45675b602ad2e338fa)
**fixed alerts:**
* 170 for Useless assignment to local variable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] pdxcodemonkey commented on pull request #728: Fix LGTM Usless Variable Assigment in C# files
Posted by GitBox <gi...@apache.org>.
pdxcodemonkey commented on pull request #728:
URL: https://github.com/apache/geode-native/pull/728#issuecomment-765719943
-DCMAKE_SYSTEM_VERSION=10.0.16299.0, see Mike's PR here: https://github.com/apache/geode-native/pull/717
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] codecov-io edited a comment on pull request #728: Fix LGTM Usless Variable Assigment in C# files
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #728:
URL: https://github.com/apache/geode-native/pull/728#issuecomment-765831326
# [Codecov](https://codecov.io/gh/apache/geode-native/pull/728?src=pr&el=h1) Report
> Merging [#728](https://codecov.io/gh/apache/geode-native/pull/728?src=pr&el=desc) (bc3fa6b) into [develop](https://codecov.io/gh/apache/geode-native/commit/bc3fa6bffb5ffc476260db0820e83fdec3b341d2?el=desc) (bc3fa6b) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/geode-native/pull/728?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #728 +/- ##
========================================
Coverage 75.29% 75.29%
========================================
Files 645 645
Lines 49779 49779
========================================
Hits 37481 37481
Misses 12298 12298
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/geode-native/pull/728?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/geode-native/pull/728?src=pr&el=footer). Last update [bc3fa6b...4b2652c](https://codecov.io/gh/apache/geode-native/pull/728?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] lgtm-com[bot] removed a comment on pull request #728: Fix LGTM Usless Variable Assigment in C# files
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] removed a comment on pull request #728:
URL: https://github.com/apache/geode-native/pull/728#issuecomment-765805998
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] lgtm-com[bot] commented on pull request #728: Fix LGTM Usless Variable Assigment in C# files
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #728:
URL: https://github.com/apache/geode-native/pull/728#issuecomment-771227116
This pull request **fixes 170 alerts** when merging b5ca05b21d031393ea4a125d36a35ff80b543ffa into a467cdefdcb6d3d300be3dbde6663c8b6217004a - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode-native/rev/pr-453009f4c3daa0ae08a23bd994984bb4622cf07d)
**fixed alerts:**
* 170 for Useless assignment to local variable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] lgtm-com[bot] commented on pull request #728: Fix LGTM Usless Variable Assigment in C# files
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #728:
URL: https://github.com/apache/geode-native/pull/728#issuecomment-780178604
This pull request **fixes 170 alerts** when merging bae3bcc735d694f6ef98ac0305767d1fc99a9f43 into 6fea972286d07364825467b0a75d92bbe34e11ba - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode-native/rev/pr-bd450f995ca3e95b6e6c22b9f6d00f176ecaccb3)
**fixed alerts:**
* 170 for Useless assignment to local variable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] moleske closed pull request #728: Fix LGTM Usless Variable Assigment in C# files
Posted by GitBox <gi...@apache.org>.
moleske closed pull request #728:
URL: https://github.com/apache/geode-native/pull/728
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] lgtm-com[bot] commented on pull request #728: Fix LGTM Usless Variable Assigment in C# files
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #728:
URL: https://github.com/apache/geode-native/pull/728#issuecomment-770097384
This pull request **fixes 170 alerts** when merging 34b8199c021a2b80d619e7668f6adf9b3306a754 into 3450baca23d07259725c8ed3832d5ef6b781f1c5 - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode-native/rev/pr-ad1f0a1a3b74256ffa430f7b354e9c6dc108a3dc)
**fixed alerts:**
* 170 for Useless assignment to local variable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] lgtm-com[bot] commented on pull request #728: Fix LGTM Usless Variable Assigment in C# files
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #728:
URL: https://github.com/apache/geode-native/pull/728#issuecomment-767229873
This pull request **fixes 170 alerts** when merging a130467c51a784b34b9aa4082abaf7078fb76454 into 9a46e7d89918c192c3edd5ff57dbfee078419883 - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode-native/rev/pr-030a2de7b7c666dec008df45675b602ad2e338fa)
**fixed alerts:**
* 170 for Useless assignment to local variable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] lgtm-com[bot] commented on pull request #728: Fix LGTM Usless Variable Assigment in C# files
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #728:
URL: https://github.com/apache/geode-native/pull/728#issuecomment-771227116
This pull request **fixes 170 alerts** when merging b5ca05b21d031393ea4a125d36a35ff80b543ffa into a467cdefdcb6d3d300be3dbde6663c8b6217004a - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode-native/rev/pr-453009f4c3daa0ae08a23bd994984bb4622cf07d)
**fixed alerts:**
* 170 for Useless assignment to local variable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] lgtm-com[bot] commented on pull request #728: Fix LGTM Usless Variable Assigment in C# files
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #728:
URL: https://github.com/apache/geode-native/pull/728#issuecomment-765720523
This pull request **fixes 65 alerts** when merging d571a732bba629905f60e234251853d8a9df531d into bc3fa6bffb5ffc476260db0820e83fdec3b341d2 - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode-native/rev/pr-86f5be11de0d05c816c3ae637d4c1ac7ec556f55)
**fixed alerts:**
* 65 for Useless assignment to local variable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] lgtm-com[bot] commented on pull request #728: Fix LGTM Usless Variable Assigment in C# files
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #728:
URL: https://github.com/apache/geode-native/pull/728#issuecomment-765808544
This pull request **fixes 206 alerts** when merging 4b2652c8bc62a70b33d4e25e1462e0d1a059e9b5 into bc3fa6bffb5ffc476260db0820e83fdec3b341d2 - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode-native/rev/pr-b5a91ea7175df4560a182eb638388859d19a6dec)
**fixed alerts:**
* 206 for Useless assignment to local variable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] codecov-io commented on pull request #728: Fix LGTM Usless Variable Assigment in C# files
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #728:
URL: https://github.com/apache/geode-native/pull/728#issuecomment-765831326
# [Codecov](https://codecov.io/gh/apache/geode-native/pull/728?src=pr&el=h1) Report
> Merging [#728](https://codecov.io/gh/apache/geode-native/pull/728?src=pr&el=desc) (bc3fa6b) into [develop](https://codecov.io/gh/apache/geode-native/commit/bc3fa6bffb5ffc476260db0820e83fdec3b341d2?el=desc) (bc3fa6b) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/geode-native/pull/728?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #728 +/- ##
========================================
Coverage 74.99% 74.99%
========================================
Files 645 645
Lines 49779 49779
========================================
Hits 37331 37331
Misses 12448 12448
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/geode-native/pull/728?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/geode-native/pull/728?src=pr&el=footer). Last update [bc3fa6b...4b2652c](https://codecov.io/gh/apache/geode-native/pull/728?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] codecov-io edited a comment on pull request #728: Fix LGTM Usless Variable Assigment in C# files
Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #728:
URL: https://github.com/apache/geode-native/pull/728#issuecomment-765831326
# [Codecov](https://codecov.io/gh/apache/geode-native/pull/728?src=pr&el=h1) Report
> Merging [#728](https://codecov.io/gh/apache/geode-native/pull/728?src=pr&el=desc) (bc3fa6b) into [develop](https://codecov.io/gh/apache/geode-native/commit/a4afaf31d9739172171f82e90201dd13abd6e1e1?el=desc) (a4afaf3) will **increase** coverage by `0.16%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/geode-native/pull/728?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## develop #728 +/- ##
===========================================
+ Coverage 75.12% 75.29% +0.16%
===========================================
Files 645 645
Lines 49763 49779 +16
===========================================
+ Hits 37386 37481 +95
+ Misses 12377 12298 -79
```
| [Impacted Files](https://codecov.io/gh/apache/geode-native/pull/728?src=pr&el=tree) | Coverage Δ | |
|---|---|---|
| [...che/src/InternalCacheTransactionManager2PCImpl.cpp](https://codecov.io/gh/apache/geode-native/pull/728/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL0ludGVybmFsQ2FjaGVUcmFuc2FjdGlvbk1hbmFnZXIyUENJbXBsLmNwcA==) | `62.35% <0.00%> (-11.77%)` | :arrow_down: |
| [...tion-test/testThinClientRemoteQueryFailoverPdx.cpp](https://codecov.io/gh/apache/geode-native/pull/728/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvaW50ZWdyYXRpb24tdGVzdC90ZXN0VGhpbkNsaWVudFJlbW90ZVF1ZXJ5RmFpbG92ZXJQZHguY3Bw) | `85.48% <0.00%> (-4.04%)` | :arrow_down: |
| [...test/testThinClientPoolExecuteHAFunctionPrSHOP.cpp](https://codecov.io/gh/apache/geode-native/pull/728/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvaW50ZWdyYXRpb24tdGVzdC90ZXN0VGhpbkNsaWVudFBvb2xFeGVjdXRlSEFGdW5jdGlvblByU0hPUC5jcHA=) | `91.20% <0.00%> (-3.71%)` | :arrow_down: |
| [cppcache/src/RegionAttributes.cpp](https://codecov.io/gh/apache/geode-native/pull/728/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1JlZ2lvbkF0dHJpYnV0ZXMuY3Bw) | `32.49% <0.00%> (-3.13%)` | :arrow_down: |
| [cppcache/src/RegionAttributesFactory.cpp](https://codecov.io/gh/apache/geode-native/pull/728/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1JlZ2lvbkF0dHJpYnV0ZXNGYWN0b3J5LmNwcA==) | `76.69% <0.00%> (-2.92%)` | :arrow_down: |
| [cppcache/src/TcpConn.cpp](https://codecov.io/gh/apache/geode-native/pull/728/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RjcENvbm4uY3Bw) | `69.76% <0.00%> (-1.29%)` | :arrow_down: |
| [cppcache/src/CacheXmlParser.cpp](https://codecov.io/gh/apache/geode-native/pull/728/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL0NhY2hlWG1sUGFyc2VyLmNwcA==) | `75.22% <0.00%> (-1.28%)` | :arrow_down: |
| [cppcache/src/RemoteQuery.cpp](https://codecov.io/gh/apache/geode-native/pull/728/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1JlbW90ZVF1ZXJ5LmNwcA==) | `78.02% <0.00%> (-1.10%)` | :arrow_down: |
| [cppcache/src/ExecutionImpl.cpp](https://codecov.io/gh/apache/geode-native/pull/728/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL0V4ZWN1dGlvbkltcGwuY3Bw) | `71.37% <0.00%> (-0.41%)` | :arrow_down: |
| [cppcache/src/ThinClientRedundancyManager.cpp](https://codecov.io/gh/apache/geode-native/pull/728/diff?src=pr&el=tree#diff-Y3BwY2FjaGUvc3JjL1RoaW5DbGllbnRSZWR1bmRhbmN5TWFuYWdlci5jcHA=) | `76.79% <0.00%> (-0.17%)` | :arrow_down: |
| ... and [9 more](https://codecov.io/gh/apache/geode-native/pull/728/diff?src=pr&el=tree-more) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/geode-native/pull/728?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/geode-native/pull/728?src=pr&el=footer). Last update [a4afaf3...bd1461d](https://codecov.io/gh/apache/geode-native/pull/728?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [geode-native] lgtm-com[bot] commented on pull request #728: Fix LGTM Usless Variable Assigment in C# files
Posted by GitBox <gi...@apache.org>.
lgtm-com[bot] commented on pull request #728:
URL: https://github.com/apache/geode-native/pull/728#issuecomment-767746714
This pull request **fixes 170 alerts** when merging bd1461dfa118e3779cf15fc39f2a1d487a723b5c into a4afaf31d9739172171f82e90201dd13abd6e1e1 - [view on LGTM.com](https://lgtm.com/projects/g/apache/geode-native/rev/pr-0d1f03dd15b1e1d318e4baa95e4a934fe8c98e0c)
**fixed alerts:**
* 170 for Useless assignment to local variable
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org