You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by caseywebdev <gi...@git.apache.org> on 2015/03/27 05:44:17 UTC

[GitHub] cordova-lib pull request: Fix plugman install failure on iOS conta...

GitHub user caseywebdev opened a pull request:

    https://github.com/apache/cordova-lib/pull/193

    Fix plugman install failure on iOS containing &

    I have an iOS project named `Foo & Bar`. When trying to run `cordova plugin add <anything>` an error is thrown:
    
    ```
    Failed to install 'org.apache.cordova.splashscreen':CordovaError: could not find -Info.plist file, or config.xml file.
        at Object.module.exports.parseProjectFile (/Users/casey/projects/example/node_modules/cordova/node_modules/cordova-lib/src/plugman/platforms/ios.js:193:19)
        at Object.ActionStack.process (/Users/casey/projects/example/node_modules/cordova/node_modules/cordova-lib/src/plugman/util/action-stack.js:55:49)
        at handleInstall (/Users/casey/projects/example/node_modules/cordova/node_modules/cordova-lib/src/plugman/install.js:575:20)
        at /Users/casey/projects/example/node_modules/cordova/node_modules/cordova-lib/src/plugman/install.js:335:28
        at _fulfilled (/Users/casey/projects/example/node_modules/cordova/node_modules/q/q.js:787:54)
        at self.promiseDispatch.done (/Users/casey/projects/example/node_modules/cordova/node_modules/q/q.js:816:30)
        at Promise.promise.promiseDispatch (/Users/casey/projects/example/node_modules/cordova/node_modules/q/q.js:749:13)
        at /Users/casey/projects/example/node_modules/cordova/node_modules/q/q.js:509:49
        at flush (/Users/casey/projects/example/node_modules/cordova/node_modules/q/q.js:108:17)
        at process._tickCallback (node.js:355:11)
    could not find -Info.plist file, or config.xml file.
    ```
    
    The problem is that the xcode parser is saying that the plist path is `Foo \& Bar-Info.plist`, which is obviously wrong as there is no actual backslash. The ampersand seems to be escaped in the `project.pbxproj` file, so I'm not sure this is the best place for the fix, or if this might even be a bug in https://github.com/alunny/node-xcode

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/caseywebdev/cordova-lib patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/193.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #193
    
----
commit cc76abd542a0b86fa9150b63ca100ef200173491
Author: Casey Foster <c...@sey.me>
Date:   2015-03-27T04:44:04Z

    Fix plugman install failure on iOS containing &
    
    I have an iOS project named `Foo & Bar`. When trying to run `cordova plugin add <anything>` an error is thrown:
    
    ```
    Failed to install 'org.apache.cordova.splashscreen':CordovaError: could not find -Info.plist file, or config.xml file.
        at Object.module.exports.parseProjectFile (/Users/casey/projects/example/node_modules/cordova/node_modules/cordova-lib/src/plugman/platforms/ios.js:193:19)
        at Object.ActionStack.process (/Users/casey/projects/example/node_modules/cordova/node_modules/cordova-lib/src/plugman/util/action-stack.js:55:49)
        at handleInstall (/Users/casey/projects/example/node_modules/cordova/node_modules/cordova-lib/src/plugman/install.js:575:20)
        at /Users/casey/projects/example/node_modules/cordova/node_modules/cordova-lib/src/plugman/install.js:335:28
        at _fulfilled (/Users/casey/projects/example/node_modules/cordova/node_modules/q/q.js:787:54)
        at self.promiseDispatch.done (/Users/casey/projects/example/node_modules/cordova/node_modules/q/q.js:816:30)
        at Promise.promise.promiseDispatch (/Users/casey/projects/example/node_modules/cordova/node_modules/q/q.js:749:13)
        at /Users/casey/projects/example/node_modules/cordova/node_modules/q/q.js:509:49
        at flush (/Users/casey/projects/example/node_modules/cordova/node_modules/q/q.js:108:17)
        at process._tickCallback (node.js:355:11)
    could not find -Info.plist file, or config.xml file.
    ```
    
    The problem is that the xcode parser is saying that the plist path is `Foo \& Bar-Info.plist`, which is obviously wrong as there is no actual backslash. The ampersand seems to be escaped in the `project.pbxproj` file, so I'm not sure this is the best place for the fix, or if this might even be a bug in https://github.com/alunny/node-xcode

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-lib pull request: Fix plugman install failure on iOS conta...

Posted by shazron <gi...@git.apache.org>.
Github user shazron commented on the pull request:

    https://github.com/apache/cordova-lib/pull/193#issuecomment-89059205
  
    Patch verified to work.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-lib pull request: Fix plugman install failure on iOS conta...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/cordova-lib/pull/193


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


[GitHub] cordova-lib pull request: Fix plugman install failure on iOS conta...

Posted by purplecabbage <gi...@git.apache.org>.
Github user purplecabbage commented on the pull request:

    https://github.com/apache/cordova-lib/pull/193#issuecomment-89059948
  
    Thanks Casey!
    You should consider signing the CLA for future contributions.
    http://cordova.apache.org/#contribute
    
    btw, Best github picture evar!


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org